Bug 689039
| Summary: | Review Request: csdp - C library for SemiDefinite Programming | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jerry James <loganjerry> |
| Component: | Package Review | Assignee: | Hedayat Vatankhah <hedayatv> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, hedayatv, notting |
| Target Milestone: | --- | Flags: | hedayatv:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | csdp-6.1.1-1.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-05-10 03:33:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jerry James
2011-03-18 21:34:04 UTC
Hi! This is my review for your package: MUST Items: ------------ RpmLint Output: % rpmlint csdp-6.1.1-1.fc14.src.rpm csdp.src: W: spelling-error %description -l en_US semidefinite -> semi definite, semi-definite, definiteness 1 packages and 0 specfiles checked; 0 errors, 1 warnings. % rpmlint noarch/csdp-octave-6.1.1-1.fc14.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. % rpmlint csdp-* csdp.x86_64: W: spelling-error %description -l en_US semidefinite -> semi definite, semi-definite, definiteness csdp.x86_64: W: shared-lib-calls-exit /usr/lib64/libsdp.so.6.1.1 exit.5 4 packages and 0 specfiles checked; 0 errors, 2 warnings. --------------------------------------------------------------------------- Built successfully in Koji. http://koji.fedoraproject.org/koji/taskinfo?taskID=3036616 Passes other MUST and SHOULD items, including Packaging Guidelines. Some notes before accepting the package: - semidefinite looks like to be an acceptable word, but if semi-definite is a better replacement please replace it - defattr can be removed from the %files sections as recently added to the Packaging Guidelines - Where does Csdp.INDEX file in src.rpm come from? Thanks for the review! (In reply to comment #1) > - semidefinite looks like to be an acceptable word, but if semi-definite is a > better replacement please replace it All of the web sites that talk about this approach use "semidefinite", so I would like to leave it that way. > - defattr can be removed from the %files sections as recently added to the > Packaging Guidelines Okay. If I don't need to make any other changes, I'll do this before importing the package into git. > - Where does Csdp.INDEX file in src.rpm come from? I made it. I can add a comment to that effect in the spec file. (In reply to comment #2) > Thanks for the review! :) You're welcome > > (In reply to comment #1) > > - semidefinite looks like to be an acceptable word, but if semi-definite is a > > better replacement please replace it > > All of the web sites that talk about this approach use "semidefinite", so I > would like to leave it that way. OK. > > > - defattr can be removed from the %files sections as recently added to the > > Packaging Guidelines > > Okay. If I don't need to make any other changes, I'll do this before importing > the package into git. > > > - Where does Csdp.INDEX file in src.rpm come from? > > I made it. I can add a comment to that effect in the spec file. Yes, please add a comment to the spec file about this. Considering that the above 2 minor edits will be applied upon import to git, this package is considered to be APPROVED by me. New Package SCM Request ======================= Package Name: csdp Short Description: C library for SemiDefinite Programming Owners: jjames Branches: f14 f15 InitialCC: Git done (by process-git-requests). csdp-6.1.1-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/csdp-6.1.1-1.fc15 csdp-6.1.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/csdp-6.1.1-1.fc14 csdp-6.1.1-1.fc15 has been pushed to the Fedora 15 testing repository. csdp-6.1.1-1.fc15 has been pushed to the Fedora 15 stable repository. csdp-6.1.1-1.fc14 has been pushed to the Fedora 14 stable repository. |