Bug 689094

Summary: virt-manager choose-cd dialog fails to reappear if dismissed with Escape hotkey
Product: [Community] Virtualization Tools Reporter: Stefan Hajnoczi <stefanha>
Component: virt-managerAssignee: Cole Robinson <crobinso>
Status: CLOSED UPSTREAM QA Contact:
Severity: low Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: berrange, crobinso, xen-maint
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-03-21 14:59:00 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Stefan Hajnoczi 2011-03-19 11:30:00 UTC
Description of problem:

The choose-cd dialog fails to appear again after being dismissed with the Escape key.  It is necessary to quit and restart virt-manager in order to get the choose-cd dialog back again.

Version-Release number of selected component (if applicable):

virt-manager.git/master and virt-manager-0.8.4-8 Debian package

Steps to Reproduce:
1. Start virt-manager and open the details for a virtual machine.
2. Select "IDE CDROM 1".
3. Click "Connect" to open the choose-cd dialog.
4. Press the Escape key (do not click cancel, this bug only affects the escape key binding).
5. Click "Connect" again.
  
Actual results:

The choose-cd dialog does not appear again when "Connect" is clicked.  The following backtrace is in the virt-manager log file:
[Sat, 19 Mar 2011 11:25:20 virt-manager 13033] DEBUG (engine:628) window counter incremented to 2
[Sat, 19 Mar 2011 11:26:23 virt-manager 13033] ERROR (virt-manager:173) Traceback (most recent call last):
  File "/usr/share/virt-manager/virtManager/details.py", line 1185, in toggle_storage_media
    dialog.show()
  File "/usr/share/virt-manager/virtManager/choosecd.py", line 81, in show
    self.reset_state()
  File "/usr/share/virt-manager/virtManager/choosecd.py", line 86, in reset_state
    use_cdrom = (cd_path.get_active() > -1)
AttributeError: 'NoneType' object has no attribute 'get_active'
None

Expected results:

The choose-cd dialog should reappear when "Connect" is clicked after it was dismissed earlier by pressing the Escape key.

Comment 1 Cole Robinson 2011-03-21 14:59:00 UTC
Thanks for the report, fixed upstream:

http://git.fedorahosted.org/git/?p=virt-manager.git;a=commit;h=f25c3b13e6cd054b2a85fdf71c058854636efd43

Comment 2 Stefan Hajnoczi 2011-03-21 19:52:17 UTC
Thank you, I have successfully tested the fix.