Bug 689329

Summary: livecd-iso-to-disk installs syslinux files in root directory
Product: [Fedora] Fedora Reporter: Frederick Grose <fgrose>
Component: livecd-toolsAssignee: Brian Lane <bcl>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: adam.stokes, bcl, bruno, dhuff, Jasper.Hartline, katzj
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-08-11 23:21:16 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Fix pipefailure in checkSyslinuxVersion()
none
Really fix pipefailure in checkSyslinuxVersion() none

Description Frederick Grose 2011-03-21 06:39:58 UTC
Created attachment 486546 [details]
Fix pipefailure in checkSyslinuxVersion()

The new set -o pipefail option, set early, changes a return value in checkSyslinuxVersion() leading to SYSLINUXPATH being set to "".

The attached patch rewrites the test. The earlier test tested the usage function in /usr/bin/syslinux.

The replacement checks the the --version output for a general 'syslinux' response.

This should exercise the installed program like the previous test, but I'm not familiar with the use case for the failure condition that leads to SYSLINUXPATH being set to "".

Comment 1 Frederick Grose 2011-03-21 07:11:59 UTC
Created attachment 486551 [details]
Really fix pipefailure in checkSyslinuxVersion()

Resubmitted patch with test operation changed from == to != as required.