Bug 689344

Summary:	fs attribute of partition tag can be optional
Product:	[Retired] Beaker	Reporter:	Marian Ganisin <mganisin>
Component:	lab controller	Assignee:	Dan Callaghan <dcallagh>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	0.6	CC:	bpeck, dcallagh, mcsontos, rmancy, stl
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-04-07 03:39:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Marian Ganisin 2011-03-21 07:05:49 UTC

Description of problem:
As I described in Bug 689338, fs attribute in partition tag is mandatory (at least sometimes). However it is working very well without that, this job demonstrates it very well:

https://beaker.engineering.redhat.com/jobs/63966

Anaconda doesn't require definition of fs type, it uses default one. I believe it is true for rhel5.x and newer, I am not sure about older versions. 

Actual results:
Web interface doesn't submit job with fs="" missing in partition tag,
command line tool schedules it, but prints error message.

Expected results:
Valid configuration, no issues during submit with missing fs="" attr.

Comment 1 Dan Callaghan 2011-03-21 07:36:13 UTC

You are right, the fs attribute is optional, although it's not an Anaconda feature but rather the rhts_partitions kickstart snippet which will fall back to ext3:

    #if len($partition) == 4
    #set fstype = $partition[3]
    #else
    #set fstype = 'ext3'
    #end if

The fs attribute should be optional in the job xml schema, so that its absence doesn't trigger validation warnings.