Bug 689400

Summary: List jobs/status client showing wrong size of Incremental backup
Product: Red Hat Enterprise Linux 6 Reporter: Bart Swedrowski <bart>
Component: baculaAssignee: Lukáš Nykrýn <lnykryn>
Status: CLOSED ERRATA QA Contact: qe-baseos-daemons
Severity: medium Docs Contact:
Priority: medium    
Version: 6.0CC: azelinka, kvolny, ovasik, pkovar
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Unspecified   
Whiteboard:
Fixed In Version: bacula-5.0.0-8.el6 Doc Type: Bug Fix
Doc Text:
Prior to this update, the backup size was computed incorrectly under certain circumstances. As a consequence, the reported size of the incremental backup could have been wrong. The problem has been fixed by correcting the backup size computation process so that the size of the incremental backup is now reported correctly.
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-08-31 09:16:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
patch from Bacula bugs system none

Description Bart Swedrowski 2011-03-21 11:39:31 UTC
Description of problem:

List jobs/status client showing wrong size of Incremental backup

Version-Release number of selected component (if applicable):

bacula-client

How reproducible:

Run incremental backup

Steps to Reproduce:
1. Run incremental backup
2. List jobs in bconsole
  
Actual results:

| 1,089 | tic FS | 2011-01-08 02:05:03 | B | F | 464,798 | 33,390,404,320 | T |
| 1,097 | tic FS | 2011-01-09 02:05:03 | B | I | 6,573 | 39,758,701,241 | T |
| 1,105 | tic FS | 2011-01-10 02:05:08 | B | I | 4,585 | 39,502,153,253 | T |
| 1,113 | tic FS | 2011-01-11 02:05:02 | B | I | 4,585 | 39,808,375,917 | T |
| 1,122 | tic FS | 2011-01-12 02:05:02 | B | I | 4,441 | 39,939,208,908 | T |
| 1,130 | tic FS | 2011-01-13 02:05:03 | B | I | 7,584 | 40,036,714,059 | T |

Additional info:

http://bugs.bacula.org/view.php?id=1685 -- bug report in Bacula bugs system.  Already fixed in upstream with patch attached that suits 5.0.0 which is shipped with RedHat6.

It would be awesome if you could port the patch back.

Comment 2 RHEL Program Management 2011-03-21 12:07:46 UTC
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unfortunately unable to
address this request at this time. Red Hat invites you to
ask your support representative to propose this request, if
appropriate and relevant, in the next release of Red Hat
Enterprise Linux. If you would like it considered as an
exception in the current release, please ask your support
representative.

Comment 4 Jan Görig 2011-05-19 14:12:25 UTC
Created attachment 499851 [details]
patch from Bacula bugs system

Comment 7 Jan Görig 2011-06-09 06:54:10 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause
 - backup size was in some cases computed incorrectly 
Consequence
 - reported size of incremental backup could be wrong
Fix
 - computation of backup size is corrected
Result
 - reported size of incremental backup is correct

Comment 8 Petr Kovar 2011-06-15 16:08:47 UTC
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,8 +1 @@
-Cause
+Prior to this update, the backup size was computed incorrectly under certain circumstances. As a consequence, the reported size of the incremental backup could have been wrong. The problem has been fixed by correcting the backup size computation process so that the size of the incremental backup is now reported correctly.- - backup size was in some cases computed incorrectly 
-Consequence
- - reported size of incremental backup could be wrong
-Fix
- - computation of backup size is corrected
-Result
- - reported size of incremental backup is correct

Comment 10 Karel Volný 2011-08-25 22:06:17 UTC
unfortunately, I'm unable to reproduce the error ... what are the exact conditions to trigger it?

- note that I've tried adding some options from http://bugs.bacula.org/view.php?id=1685 but it did not help

to be precise, I use:

FileSet {
  Name = "Full Set"
  Include {
    Options {
      signature = SHA1
      Accurate = mcs1
      basejob = pmugcs1
      checkfilechanges= yes
      compression = GZIP
      verify = pins1
    }
...

Comment 12 Bart Swedrowski 2011-08-26 06:23:02 UTC
You need to run Full backup and then Incrementals.  Each incremental will be taking the same amount of space as Full according to bconsole (eg. in `list jobs`).

Comment 13 Karel Volný 2011-08-26 10:57:46 UTC
(In reply to comment #12)
> You need to run Full backup and then Incrementals.

that's what I did

> Each incremental will be taking the same amount of space as Full according
> to bconsole (eg. in `list jobs`).

when I add to the directory backed up half of the initial size before each incremental backup, it reports half the size of the first full backup for the incremental:

+-------+---------------+---------------------+------+-------+----------+----------+-----------+
| JobId | Name          | StartTime           | Type | Level | JobFiles | JobBytes | JobStatus |
+-------+---------------+---------------------+------+-------+----------+----------+-----------+
| 1     | BackupClient1 | 2011-08-26 06:49:32 | B    | F     | 101      | 103500   | T         |
| 2     | BackupClient1 | 2011-08-26 06:49:47 | B    | I     | 51       | 51750    | T         |
| 3     | BackupClient1 | 2011-08-26 06:49:57 | B    | I     | 51       | 51750    | T         |
| 4     | BackupClient1 | 2011-08-26 06:50:08 | B    | I     | 51       | 51750    | T         |
| 5     | BackupClient1 | 2011-08-26 06:50:18 | B    | I     | 51       | 51750    | T         |
| 6     | BackupClient1 | 2011-08-26 06:50:28 | B    | I     | 51       | 51750    | T         |
| 7     | BackupClient1 | 2011-08-26 06:50:39 | B    | I     | 51       | 51750    | T         |
| 8     | BackupClient1 | 2011-08-26 06:50:49 | B    | I     | 51       | 51750    | T         |
| 9     | BackupClient1 | 2011-08-26 06:50:59 | B    | I     | 51       | 51750    | T         |
| 10    | BackupClient1 | 2011-08-26 06:51:10 | B    | I     | 51       | 51750    | T         |
| 11    | BackupClient1 | 2011-08-26 06:51:20 | B    | I     | 51       | 51750    | T         |
+-------+---------------+---------------------+------+-------+----------+----------+-----------+

Comment 14 Karel Volný 2011-08-29 16:24:39 UTC
SanityOnly - I'm unable to reproduce the error

the patch is applied cleanly during the build and is reported (in upstream bugtracker) to fix the issue

the test /CoreOS/bacula/Sanity/backup-restore-sqlite which utilises incremental backups works with the new version (as well as with the old ...)

Comment 15 errata-xmlrpc 2011-08-31 09:16:10 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-1232.html