Bug 689593

Summary: Should netfs mount GFS2 partitions?
Product: Red Hat Enterprise Linux 6 Reporter: Colin.Simpson
Component: initscriptsAssignee: initscripts Maintenance Team <initscripts-maint-list>
Status: CLOSED ERRATA QA Contact: qe-baseos-daemons
Severity: medium Docs Contact:
Priority: medium    
Version: 6.0CC: asersen, azelinka, plautrba, steved, swhiteho
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: initscripts-9.03.24-1.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 18:09:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 435906    
Bug Blocks:    
Attachments:
Description Flags
Patch to fix the netfs script for gfs2 swhiteho: review? (notting)

Description Colin.Simpson 2011-03-21 20:41:23 UTC
Description of problem:
Should /etc/init.d/netfs mount GFS2 filesystems when there is a /etc/init.d/gfs2 separate init script?

netfs has a line:
action $"Mounting other filesystems: " mount -a -t nonfs,nfs4,cifs,ncpfs,gfs

If so, what is GFS2's init script really for?

Comment 2 Steve Whitehouse 2011-03-22 09:00:21 UTC
gfs != gfs2 and since this is rhel6, gfs doesn't even exist. The gfs2 init script does mount the gfs2 filesystems, however this is not really correct. We have a bug open which is bug #435906 which is requesting a change to allow these mounts to work correctly.

This is currently blocked on upstream work. I've not heard anything recently about progress.

Comment 3 Bill Nottingham 2011-03-22 14:29:15 UTC
That line means it should *not* mount gfs filesystems... probably needs expanded to GFS2. Just FYI.

Comment 4 Colin.Simpson 2011-03-22 18:17:34 UTC
gfs may not equal gfs2 but the /etc/init.d/netfs tried to mount GFS2 filesystems even though it says "gfs" in the mount line!

Until upstream work is complete and given plain gfs is gone, should it not just have this removed from netfs?

Comment 5 Bill Nottingham 2011-03-22 18:21:49 UTC
As I said, that line is telling it to *not* mount gfs (or nfs, or ncpfs) filesystems. So it's expected that that line might mount gfs2.

Comment 6 Colin.Simpson 2011-03-22 18:36:23 UTC
Ahh, sorry all is clear.

Comment 7 RHEL Program Management 2011-04-04 02:11:18 UTC
Since RHEL 6.1 External Beta has begun, and this bug remains
unresolved, it has been rejected as it is not proposed as
exception or blocker.

Red Hat invites you to ask your support representative to
propose this request, if appropriate and relevant, in the
next release of Red Hat Enterprise Linux.

Comment 8 Steve Whitehouse 2011-05-12 14:44:23 UTC
So do we still need this bug now? or is there nothing to fix.

Comment 9 Colin.Simpson 2011-05-12 15:40:37 UTC
It's still trying to mount gfs2 filesystems in /etc/init.d/netfs as far as I can see (not sure if fixed in 6.1). I thought we'd decided it shouldn't be and this needs to be fixed (the gfs2 startup script does this).

Comment 10 Steve Whitehouse 2011-08-01 10:18:56 UTC
Created attachment 516109 [details]
Patch to fix the netfs script for gfs2

I think this is all that needs doing... this will ensure that gfs2 is not mounted as part of "all the other filesystems" from netfs and thus will be left for the gfs2 script to mount/umount.

Comment 13 Bill Nottingham 2011-08-01 20:12:59 UTC
Looks reasonable.

Comment 14 Bill Nottingham 2011-08-01 20:13:59 UTC
That is commit 2d3dfa0 on master, FWIW.

Comment 18 errata-xmlrpc 2011-12-06 18:09:18 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1528.html