| Summary: | fcoemon incorrectly chooses fcoe driver for netxtreme2 interfaces | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Bhanu Prakash Gollapudi <bprakash> | ||||||
| Component: | fcoe-utils | Assignee: | Petr Šabata <psabata> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | BaseOS QE Security Team <qe-baseos-security> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | high | ||||||||
| Version: | 6.1 | CC: | ademcho, bprakash, cward, echo, mchan, mvadkert, nsujir | ||||||
| Target Milestone: | rc | Keywords: | OtherQA, Patch | ||||||
| Target Release: | 6.1 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | fcoe-utils-1.0.17-7.el6 | Doc Type: | Bug Fix | ||||||
| Doc Text: |
Cause
Unsuccessfully retry VLAN discovery 10 times.
Consequence
The default fallback 'fcoe' driver is used instead of the preferred one.
Fix
Retry VLAN discovery indefinitely.
Result
FCoE interfaces are now created only upon VLAN discovery, with proper
drivers.
|
Story Points: | --- | ||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2011-05-19 14:20:30 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Attachments: |
|
||||||||
|
Description
Bhanu Prakash Gollapudi
2011-03-21 22:53:36 UTC
Patch has been submitted upstream and pending approval.
http://www.open-fcoe.org/patchwork/patch/1784/
(In reply to comment #2) > Patch has been submitted upstream and pending approval. > http://www.open-fcoe.org/patchwork/patch/1784/ Wouldn't it be better to configure the number of retries with, say, 0 or -1 meaning forever? Anyhow, requesting devel_ack & qa_ack for this. I expect this patch to get accepted upstream. Bhanu, please note today is basically the last day for userspace patches to make it into el6.1. Adding dev_ack, this patch is needed for better usability. Created attachment 486802 [details]
Add VLAN_DISC_FOREVER config option
We got a review comment from Robert Love to avoid adding another config option and treat FCOE_ENABLE & AUTO_VLAN as the condition to continue the retry of vlan discovery forever. We'll test it and submit the patch soon (by end of today) Created attachment 486941 [details]
updated patch to make vlan disc retry forever as per Robert Love's comments
Applied in CVS, fcoe-utils-1.0.17-7.el6 Doing SanityOnly testing: * Latest release of RHEL6.1 contains fcoe-utils-1.0.17-7.el6.x86_64 * All available RHTS tests PASS: /CoreOS/fcoe-utils/Regression/bz503165-running-fcoeadm-before-loading-fcoe-stack-tracebacks /CoreOS/fcoe-utils/Regression/bz619604-fcoe-utils-enabled-in-2345-by-default /CoreOS/fcoe-utils/Sanity/init-scripts-LSB /CoreOS/fcoe-utils/Sanity/long-form-options * rebuilding src.rpm without issues on all archs with the latest RHEL6.1 packages: kernel-2.6.32-122.el6.x86_64 lldpad-0.9.41-2.el6.x86_64 The patch is applied: + echo 'Patch #16 (fcoe-utils-1.0.17-retry-vlan-discovery-forever.patch):' Patch #16 (fcoe-utils-1.0.17-retry-vlan-discovery-forever.patch): + /bin/cat /root/rpmbuild/SOURCES/fcoe-utils-1.0.17-retry-vlan-discovery-forever.patch + /usr/bin/patch -s -p1 -b --suffix .retry-vlan-discovery-forever --fuzz=0 ~~ Partners and Customers ~~ This bug was included in RHEL 6.1 Beta. Please confirm the status of this request as soon as possible. If you're having problems accessing 6.1 bits, are delayed in your test execution or find in testing that the request was not addressed adequately, please let us know. Thanks! @OtherQA feedback contact person, please update us with the latest available test results confirming the resolution of this request. Thank you. Fix verified by triggering VLAN discovery 100 times. Never fell back to "fcoe" driver instead of "bnx2fc" driver.
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
New Contents:
Cause
Unsuccessfully retry VLAN discovery 10 times.
Consequence
The default fallback 'fcoe' driver is used instead of the preferred one.
Fix
Retry VLAN discovery indefinitely.
Result
FCoE interfaces are now created only upon VLAN discovery, with proper
drivers.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2011-0743.html |