Bug 689715

Summary: crash when parsing unsupported network card link mode
Product: Red Hat Enterprise Linux 6 Reporter: sverrel
Component: tunedAssignee: Jan Vcelak <jvcelak>
Status: CLOSED ERRATA QA Contact: qe-baseos-daemons
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.0CC: azelinka, jscotka, ovasik, sverrel, tsmetana
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: tuned-0.2.19-4.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-19 13:14:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description sverrel 2011-03-22 09:23:36 UTC
Description of problem:


Version-Release number of selected component (if applicable):
tuned-0.2.11-8.el6_0.1.noarch

How reproducible:
service tuned restart

  
Actual results:

Traceback (most recent call last):
  File "/usr/sbin/tuned", line 92, in <module>
    tuned.init(TUNEDDIR, cfgfile, debug = debug)
  File "/usr/share/tuned/tuned.py", line 82, in init
    self.__initplugins__(path, "monitorplugins", self.mp)
  File "/usr/share/tuned/tuned.py", line 43, in __initplugins__
    exec _cmd
  File "<string>", line 1, in <module>
  File "/usr/share/tuned/monitorplugins/net.py", line 113, in <module>
    _plugin = NetMonitor()
  File "/usr/share/tuned/monitorplugins/net.py", line 41, in __init__
    max_speed = self.__calcspeed__( ethcard(d).get_max_speed() );
  File "/usr/share/tuned/tuned_nettool.py", line 221, in ethcard
    ethcard.list[interface] = Nettool(interface)
  File "/usr/share/tuned/tuned_nettool.py", line 40, in __init__
    self.update()
  File "/usr/share/tuned/tuned_nettool.py", line 213, in update
    self.advertised_modes.append(1000, True)
TypeError: append() takes exactly one argument (2 given)

Expected results:


Additional info:
# ethtool eth0

Settings for eth0:
	Supported ports: [ FIBRE ]
	Supported link modes:   1000baseT/Full 
	                        2500baseX/Full 
	                        10000baseT/Full 
	Supports auto-negotiation: Yes
	Advertised link modes:  1000baseT/Full 
	                        2500baseX/Full 
	                        10000baseT/Full 
	Advertised pause frame use: Symmetric Receive-only
	Advertised auto-negotiation: Yes
	Speed: 1000Mb/s
	Duplex: Full
	Port: FIBRE
	PHYAD: 16
	Transceiver: internal
	Auto-negotiation: on
	Supports Wake-on: g
	Wake-on: g
	Current message level: 0x00000000 (0)
	Link detected: yes

---- 
# cat /proc/net/dev

Inter-|   Receive                                                |  Transmit
 face |bytes    packets errs drop fifo frame compressed multicast|bytes    packets errs drop fifo colls carrier compressed
    lo:       0       0    0    0    0     0          0         0        0       0    0    0    0     0       0          0
  eth0: 1204348   11932    0    0    0     0          0         0  2211453    9873    0    0    0     0       0          0
  eth1:       0       0    0    0    0     0          0         0        0       0    0    0    0     0       0          0

I think the error is from line 231 of /usr/share/tuned/tuned_nettool.py :

self.advertised_modes.append(1000, True)

Comment 9 errata-xmlrpc 2011-05-19 13:14:10 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0581.html