Bug 689787

Summary:	Profiling window too small to cover full extent of the instrument
Product:	[Fedora] Fedora	Reporter:	Daniel Berrangé <berrange>
Component:	gnome-color-manager	Assignee:	Richard Hughes <rhughes>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	14	CC:	rhughes
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-11-15 12:26:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Daniel Berrangé 2011-03-22 13:00:30 UTC

Description of problem:
I have the following instrument:

  "X-Rite, Inc. X-Rite DTP94 [Quato Silver Haze Pro]"

On some, but not all, monitors the window that g-c-m displays the colour patches in is too small to fully cover the shielded area of the instrument. This allows light to leak in from outside the patch area being measured.

The window displaying colour patches needs to be at least 100 pixels larger in both directions to comfortably cover the full extent of the instrument.

On the following monitor the patch window is physically too small:

  LVDS1 connected 1680x1050+1680+0 (normal left inverted right x axis y axis) 331mm x 207mm

While, for comparison, on the following monitor the patch window is easily large enough:

  VGA1 connected 1680x1050+0+0 (normal left inverted right x axis y axis) 459mm x 296mm



Version-Release number of selected component (if applicable):
gnome-color-manager-2.32.0-2.fc14.x86_64

How reproducible:
Depends on the monitor

Steps to Reproduce:
1. Open gnome-color-manager
2. Select the builtin LCD on the Lenovo t500
3. Start calibration using a  X-Rite DTP94
  
Actual results:
The color patch window is too small

Expected results:
The color patch window is larger than the instrument

Additional info:

Comment 1 Richard Hughes 2011-03-24 11:11:12 UTC

(In reply to comment #0)
> On some, but not all, monitors the window that g-c-m displays the colour
> patches in is too small to fully cover the shielded area of the instrument.
> This allows light to leak in from outside the patch area being measured.

Eeek, uncool.

> The window displaying colour patches needs to be at least 100 pixels larger in
> both directions to comfortably cover the full extent of the instrument.
> 
> On the following monitor the patch window is physically too small:
> While, for comparison, on the following monitor the patch window is easily
> large enough:

I guess this depends on your DPI. Ideally, we want to say "create the window 7cm by 7cm" but this would depend on your DPI being correctly set for each monitor. I think it's probably just safer to increase the size of the box a little.

commit 38b03c147b0d5313a8948cdba7bab1db889f6fef
Author: Richard Hughes <richard>
Date:   Thu Mar 24 11:09:26 2011 +0000

    Make the argyllcms calibration square 20% larger. Fixes rh#689787

I'll backport this into 2.30 and 2.32 later this week, thanks for reporting the issue.