Bug 689797

Summary: Review Request: perl-Task-Kensho-Toolchain - Task::Kensho::Toolchain Perl module
Product: [Fedora] Fedora Reporter: Marcela Mašláňová <mmaslano>
Component: Package ReviewAssignee: Mario Blättermann <mario.blaettermann>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: fedora-package-review, mario.blaettermann, notting
Target Milestone: ---Flags: mario.blaettermann: fedora-review+
j: fedora-cvs+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-10 16:14:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Marcela Mašláňová 2011-03-22 13:37:09 UTC
SRPM: http://mmaslano.fedorapeople.org/review/perl-Task-Kensho-Toolchain-0.27-1.fc14.src.rpm
SPEC: http://mmaslano.fedorapeople.org/review/perl-Task-Kensho-Toolchain.spec
Description:
Kenshō (見性) (C. Wu) is a Japanese term for enlightenment
experiences—most commonly used within the confines of Zen
Buddhism—literally meaning "seeing one's nature"[1] or "true self."[2] It
generally "refers to the realization of nonduality of subject and
object."[3]

Task::Kensho is a first cut at building a list of recommended modules for
Enlightened Perl development. CPAN is wonderful, but there are too many
wheels and you have to pick and choose amongst the various competing
technologies.

Comment 1 Mario Blättermann 2011-05-08 15:54:27 UTC
Koji scratch build for f15:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3058311

$ rpmlint -v *
perl-Task-Kensho-Toolchain.src: I: checking
perl-Task-Kensho-Toolchain.src: W: spelling-error %description -l en_US Kenshō 
perl-Task-Kensho-Toolchain.src: W: spelling-error %description -l en_US nonduality -> non duality, non-duality, individuality
perl-Task-Kensho-Toolchain.src: I: checking-url http://search.cpan.org/dist/Task-Kensho-Toolchain/ (timeout 10 seconds)
perl-Task-Kensho-Toolchain.src: I: checking-url http://www.cpan.org/authors/id/A/AP/APEIRON/Task-Kensho-Toolchain-0.27.tar.gz (timeout 10 seconds)
perl-Task-Kensho-Toolchain.noarch: I: checking
perl-Task-Kensho-Toolchain.noarch: W: spelling-error %description -l en_US Kenshō 
perl-Task-Kensho-Toolchain.noarch: W: spelling-error %description -l en_US nonduality -> non duality, non-duality, individuality
perl-Task-Kensho-Toolchain.noarch: I: checking-url http://search.cpan.org/dist/Task-Kensho-Toolchain/ (timeout 10 seconds)
perl-Task-Kensho-Toolchain.spec: I: checking-url http://www.cpan.org/authors/id/A/AP/APEIRON/Task-Kensho-Toolchain-0.27.tar.gz (timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

A spelling error. I would recommend the proposed "non-duality".

Comment 2 Marcela Mašláňová 2011-05-09 08:51:39 UTC
Because English is not my first language, I do not change what upstream wrote. In my opinion change of description given by upstream into proper American English don't make sense.

Comment 3 Mario Blättermann 2011-05-09 18:42:34 UTC
---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
    GPL+ or Artistic
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
    $ md5sum *
    c1dc5ff6f2533dcf2d79123618e993f2  Task-Kensho-Toolchain-0.27.tar.gz
    c1dc5ff6f2533dcf2d79123618e993f2  Task-Kensho-Toolchain-0.27.tar.gz.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
    - Succesful Koji build available.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. 
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[.] SHOULD: If the source package does not include license text(s) as a
    separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
    See Koji build above (which uses mock anyway)
[+] SHOULD: The reviewer should test that the package functions as described.
    I assume the packager has tested it. Don't know how to test it on my
system.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[.] SHOULD: Your package should contain man pages for binaries/scripts.

----------------

PACKAGE APPROVED

----------------

Comment 4 Marcela Mašláňová 2011-05-10 07:33:51 UTC
New Package SCM Request
=======================
Package Name: perl-Task-Kensho-Toolchain
Short Description: Task::Kensho::Toolchain Perl module
Owners: mmaslano psabata ppisar
Branches: 
InitialCC: perl-sig

Comment 5 Jason Tibbitts 2011-05-10 15:28:50 UTC
Git done (by process-git-requests).