Bug 689927

Summary:	CDS and repo syncs needs to be audited.
Product:	[Retired] Pulp	Reporter:	Preethi Thomas <pthomas>
Component:	nodes	Assignee:	Jay Dobies <jason.dobies>
Status:	CLOSED NEXTRELEASE	QA Contact:	Preethi Thomas <pthomas>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	jason.dobies, skarmark
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	683933	Environment:
Last Closed:	2012-07-11 19:20:05 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Preethi Thomas 2011-03-22 19:50:42 UTC

+++ This bug was initially created as a clone of Bug #683933 +++

Something changed between December and now because this used to work.

When a task is created, it pulls out the name of the function it's going to execute (callable.__name__). If this method is decorated with @audit, this name will be returned as "_audit".

This has the effect that the lookup for tasks by method name, something we do for both repo and CDS syncs, will fail because the method name isn't properly captured.

Repo sync was already unaudited so this isn't an issue there. For now, I removed the audit decorator from CDS sync until this is fixed.

--- Additional comment from jason.dobies on 2011-03-22 15:17:18 EDT ---

There's no direct way to verify this. However, this leads to the bigger issue that CDS and repo syncs aren't audited.

Please file a new bug that those should be audited. That will be able to be verified by just looking at the audit logs. I'll leave it to you to decide what to do about this bug, either close it or make it dependent on the new bug to show this is correctly fixed and allows for CDS/repo sync auditing.

Comment 1 Preethi Thomas 2011-03-22 19:52:44 UTC

*** Bug 683933 has been marked as a duplicate of this bug. ***

Comment 2 Jay Dobies 2012-07-11 19:20:05 UTC

Closing this out; auditing is set to be completely rewritten in v2 and this code no longer exists.