Bug 690078

Summary: bugs in procps-3.2.8-pmap-smaps.patch and dlopen leakage
Product: Red Hat Enterprise Linux 6 Reporter: Jan Görig <jgorig>
Component: procpsAssignee: Jaromír Cápík <jcapik>
Status: CLOSED ERRATA QA Contact: BaseOS QE - Apps <qe-baseos-apps>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.2CC: albert, bnater, kdudka, ovasik, syeghiay
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: procps-3.2.8-18.el6 Doc Type: Bug Fix
Doc Text:
Cause - selinux library was linked to ps in run time and wasn't correctly closed - extended format in pmap was using incorrectly declared variables Consequence - memory leak occurs when showing selinux flags - pmap could have unexpected behaviour Fix - selinux library is now linked to ps in build time - variables are nullified and declared in correct place Result - memory leak doesn't occur now - pmap doesn't rely on random circumstances
Story Points: ---
Clone Of: 684031 Environment:
Last Closed: 2011-12-06 09:57:19 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 684031    
Bug Blocks:    
Attachments:
Description Flags
Proposed changed procps-3.2.8-pmap-smaps.patch none

Comment 2 Jan Görig 2011-03-30 09:42:40 UTC
Created attachment 488713 [details]
Proposed changed procps-3.2.8-pmap-smaps.patch

Changed procps-3.2.8-pmap-smaps.patch. Variables are nullified and moved to right position.

Comment 3 Kamil Dudka 2011-03-31 09:16:39 UTC
Why do you initialize 'start' outside the loop (only once) and 'end' inside the loop (per each iteration)?  Both of them are read by the same sscanf().

Comment 4 Jan Görig 2011-03-31 09:34:11 UTC
Yes, that is right. Initialization of 'start' is outside the loop because it is used in next iterations. 'end' is used only in the same iteration as sscanf.

Comment 8 Jan Görig 2011-06-23 12:41:46 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause
- selinux library was linked to ps in run time and wasn't correctly closed
- extended format in pmap was using incorrectly declared variables
Consequence
- memory leak occurs when showing selinux flags
- pmap could have unexpected behaviour
Fix
- selinux library is now linked to ps in build time
- variables are nullified and declared in correct place
Result
- memory leak doesn't occur now
- pmap doesn't rely on random circumstances

Comment 11 errata-xmlrpc 2011-12-06 09:57:19 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1554.html