Bug 690146

Summary: Can not show the dialog "Add new virtual hardware" when libvirtd restart
Product: Red Hat Enterprise Linux 6 Reporter: Nan Zhang <nzhang>
Component: virt-managerAssignee: Cole Robinson <crobinso>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: high Docs Contact:
Priority: high    
Version: 6.1CC: dyuan, hjiang, llim, mzhan
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
No description necessary
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 16:07:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Nan Zhang 2011-03-23 12:51:46 UTC
Description of problem:
as subject

Version-Release number of selected component (if applicable):
virt-manager-0.8.6-3.el6.noarch

How reproducible:
Always

Steps to Reproduce:
1. Start virt-manager -> Open a guest
2. Restart libvirtd
3. Click "Show virtual hardware details" -> "Add Hardware"
  
Actual results:
Can not show up the dialog "Add new virtual hardware".

Expected results:
It will show "Add new virtual hardware" dialog.

Additional info:
You have to restart virt-manager to workaround.

Comment 2 Nan Zhang 2011-03-23 13:00:51 UTC
Clarify the reproduced steps:

1. Start virt-manager
2. Restart libvirtd
3. Connect to 'localhost'
4. Double click the guest to open the graphical console
5. Click "Show virtual hardware details" -> "Add Hardware"

Comment 3 Cole Robinson 2011-03-23 14:36:22 UTC
Ah, good catch! In the future, if a dialog doesn't launch as expected, a traceback can usually be found in the debug output, so please always report the output of running virt-manager --debug.

There are a couple problems here. One is that we aren't reporting the error to the user. Fixed upstream here:

http://git.fedorahosted.org/git?p=virt-manager.git;a=commit;h=0c0b977df46272b70f7f62b573889dc59c4bac24

The root of the problem is that we weren't clearing the iface list cache when the connection was closed. Since libvirt was restarted, the cached iface objects are no longer valid, and throw errors when we try to parse their XML, which is what the 'add hardware' dialog was doing. Fixed now:

http://git.fedorahosted.org/git?p=virt-manager.git;a=commit;h=fe703839b9e3cf978b8abd375f2f0e04baa7ac6a

Comment 4 RHEL Program Management 2011-04-04 01:48:01 UTC
Since RHEL 6.1 External Beta has begun, and this bug remains
unresolved, it has been rejected as it is not proposed as
exception or blocker.

Red Hat invites you to ask your support representative to
propose this request, if appropriate and relevant, in the
next release of Red Hat Enterprise Linux.

Comment 5 Cole Robinson 2011-07-28 15:30:46 UTC
Fixed in virt-manager-0.9.0-2.el6

Comment 7 Huming Jiang 2011-08-04 07:10:34 UTC
verified with the following components:
virt-manager-0.9.0-5.el6.x86_64
libvirt-0.9.4-1.el6.x86_64

Steps:
1. #virt-manager --dubug
2. Restart libvirtd
3. Connect to 'localhost'
4. Double click the guest to open the graphical console
5. Click "Show virtual hardware details" -> "Add Hardware"
"Add Hardware" dialog is pop-up.

additional info:
#virt-manager --dubg
...
2011-08-04 15:07:01,306 (engine:453): Could not refresh connection qemu:///system.
Traceback (most recent call last):
  File "/usr/share/virt-manager/virtManager/engine.py", line 440, in _tick
    conn.tick()
  File "/usr/share/virt-manager/virtManager/connection.py", line 1410, in tick
    self.hostinfo = self.vmm.getInfo()
  File "/usr/lib64/python2.6/site-packages/libvirt.py", line 2697, in getInfo
    if ret is None: raise libvirtError ('virNodeGetInfo() failed', conn=self)
libvirtError: Cannot write data: Broken pipe
2011-08-04 15:07:01,311 (engine:454): Closing connection since libvirtd appears to have stopped.
...

Comment 8 Cole Robinson 2011-11-07 16:37:45 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No description necessary

Comment 9 errata-xmlrpc 2011-12-06 16:07:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1642.html