Bug 690214

Summary: PATCH: fix xsel overflow of supported_targets array
Product: [Fedora] Fedora Reporter: Hans de Goede <hdegoede>
Component: xselAssignee: Rakesh Pandit <rpandit>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: alevy, rpandit
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: xsel-1.2.0-8.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-04-06 19:10:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
PATCH: fix xsel overflow of supported_targets array none

Description Hans de Goede 2011-03-23 15:47:59 UTC
Created attachment 487077 [details]
PATCH: fix xsel overflow of supported_targets array

Hi,

I'm one of the developers of spice (a remote virtual machine viewing protocol ala vnc / rdp). One of the features of spice is copy / paste between the guest and the client, while testing copy and paste with xsel, the spice-client crashed with a BadAtom error. This is caused by the spice-client getting the TARGETS property, and then for debugging purposes doing a XGetAtomName on all reported target Atoms. xsel however claims to send 9 targets, but only send 8 Atoms + 1 piece of random data from memory.

The attached patch fixes this.

Regards,

Hans


p.s.

I've also send this patch upstream and CC-ed you on that mail.

Comment 1 Hans de Goede 2011-03-30 07:27:40 UTC
I just got an email from upstream that they've accepted my patch and merged in into their git tree. Can we please get a Fedora package with this fix included build?

Comment 2 Rakesh Pandit 2011-03-30 08:31:45 UTC
(In reply to comment #1)
> I just got an email from upstream that they've accepted my patch and merged in
> into their git tree. Can we please get a Fedora package with this fix included
> build?

I will do it today.

Comment 3 Rakesh Pandit 2011-04-06 19:10:05 UTC
Thanks Hans and sorry for being late.

commit ab2556fa7f66c61f24d09da0915e2c23761ef68c
Author: Rakesh Pandit <rakesh>
Date:   Thu Apr 7 00:45:45 2011 +0530

    fix xsel overflow of supported_targets array (BZ#690214)
    (Thanks Hans de Goede)

Comment 4 Fedora Update System 2011-10-16 23:57:46 UTC
xsel-1.2.0-8.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/xsel-1.2.0-8.el6

Comment 5 Fedora Update System 2011-11-14 18:56:35 UTC
xsel-1.2.0-8.el6 has been pushed to the Fedora EPEL 6 stable repository.