Bug 690257

Summary: Don't offer to install Debian packages
Product: [Fedora] Fedora Reporter: Ville Skyttä <ville.skytta>
Component: gnome-packagekitAssignee: Richard Hughes <rhughes>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 14CC: rhughes
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-16 21:34:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Failure dialog none

Description Ville Skyttä 2011-03-23 17:57:54 UTC
Offering to install Debian packages on a Fedora system doesn't sound like a good idea to me.  Fix:

@@ -79,2 +79,3 @@
     --dir=$RPM_BUILD_ROOT%{_datadir}/applications/                      \
+    --remove-mime-type=application/x-deb                                \
     $RPM_BUILD_ROOT%{_datadir}/applications/$i.desktop

Comment 1 Richard Hughes 2011-03-24 08:54:21 UTC
We deliberately do that, so that the user gets a "You can't do that Dave" message, rather than a file extension know known dialog.

If you think it's saner to just not handle the x-deb type then your fix makes sense.

Comment 2 Ville Skyttä 2011-03-24 17:34:13 UTC
Created attachment 487400 [details]
Failure dialog

That makes sense, but the dialog displayed in my opinion is actually worse than a "file extension not known", see attachment (current F-14 x86_64).  It says "The file is not valid" which makes no sense to me in the first place (something like "This package format is not supported on this system" would be better), and "MIME type not supported ..." in the details which kind of begs the question why did the package installer register to handle that particular MIME type, then?

BTW if gpk did not register to handle these files, they would be opened with File Roller at least in my GNOME setup, so there would be no "unknown file type" or the like messages.

As it stands now, I think it would be better to remove association with MIME types that are known to not work on a Fedora system.  But if the dialog would be improved and offered a fallback option for opening with File Roller, then it'd be the best of both worlds I think.  For example something like this:

+------------------------------------------------------------------------+
| Failed to install file                                                 |
|                                                                        |
| This package format is not supported on this system.                   |
|                                                                        |
| More details                                                           |
| Packages of type application/x-deb (Debian package) are usually meant  |
| for Debian and Ubuntu systems and are not installable on this system.  |
| The package formats supported on this system are: [...]                |
| You can use Archive Manager to browse the contents of the package.     |
|                                                                        |
|                         [Open with Archive Manager]  [Close]           |
+------------------------------------------------------------------------+

Comment 3 Fedora End Of Life 2012-08-16 21:34:22 UTC
This message is a notice that Fedora 14 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 14. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained.  At this time, all open bugs with a Fedora 'version'
of '14' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this 
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen 
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we were unable to fix it before Fedora 14 reached end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" (top right of this page) and open it against that 
version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping