| Summary: | Review Request: be - Bugs Everywhere, a distributed bug tracker | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Alexandre Salim <michel> |
| Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, lemenkov, ndbecker2, notting |
| Target Milestone: | --- | Flags: | lemenkov:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | be-1.0.0-2.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-03-30 05:40:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Michel Alexandre Salim
2011-03-23 23:03:32 UTC
I'll review it. Koji scratchbuild for F-15: http://koji.fedoraproject.org/koji/taskinfo?taskID=2940018 REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
- rpmlint is not silent
work ~: rpmlint Desktop/be-1.0.0-1.fc15.*
be.noarch: W: non-standard-group Unspecified
be.src: W: non-standard-group Unspecified
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
work ~:
Please, add Group tag to make rpmlint silent.
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format %{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines.
+ The License field in the package spec file matches the actual license (GPLv2 or later).
+ The file, containing the text of the license(s) for the package, is included in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided in the spec URL.
sulaco ~/rpmbuild/SOURCES: sha256sum be-1.0.0.tar.gz*
f63bf64d058505f192c5b64a40fcb2cca6da24979eae0d5b08ab1c5e5dbcc700 be-1.0.0.tar.gz
f63bf64d058505f192c5b64a40fcb2cca6da24979eae0d5b08ab1c5e5dbcc700 be-1.0.0.tar.gz.1
sulaco ~/rpmbuild/SOURCES:
+ The package successfully compiles and builds into binary rpms on at least one primary architecture. See koji link above.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files.
+ The package does NOT bundle copies of system libraries.
+ The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files listings.
+ Permissions on files are set properly.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does own files or directories already owned by other packages, namely /etc/bash_completion.d. Co-ownership of this particular directory is de-facto acceptable.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.
Please, suppress the only rpmlint message and I'll continue.
rpmlint really needs to be updated -- Group and %defattr are both deprecated (as you can see I added a comment marking that it's only there to appease rpmlint). But yes, adding those does not hurt. RPMlint is silent on F-15. what version do you have? [salim@fauix11 gnome]$ rpmlint ./be-1.0.0-1.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [salim@fauix11 gnome]$ rpmlint ~/Downloads/be-1.0.0-1.fc15.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [salim@fauix11 gnome]$ rpm -q rpmlint rpmlint-1.1-3.fc15.noarch Updated package: Spec: http://salimma.fedorapeople.org/specs/devtools/be.spec SRPM: http://salimma.fedorapeople.org/specs/devtools/be-1.0.0-2.fc15.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2942413 That should fix the issue. And thanks again! Ok, good. I can't see any other issues (and my old rpmlint 1.0.2 is happy now) so this package is APPROVED. Thanks, Peter. New Package SCM Request ======================= Package Name: be Short Description: Bugs Everywhere, a distributed bug tracker Owners: salimma Branches: el5 el6 f14 f15 InitialCC: Git done (by process-git-requests). be-1.0.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/be-1.0.0-2.el6 be-1.0.0-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/be-1.0.0-2.el5 be-1.0.0-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/be-1.0.0-2.fc14 be-1.0.0-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/be-1.0.0-2.fc15 be-1.0.0-2.fc15 has been pushed to the Fedora 15 testing repository. be-1.0.0-2.fc15 has been pushed to the Fedora 15 stable repository. be-1.0.0-2.fc14 has been pushed to the Fedora 14 stable repository. be-1.0.0-2.el5 has been pushed to the Fedora EPEL 5 stable repository. be-1.0.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository. |