Bug 690669

Summary: Translation editor table shows changes which failed to save
Product: [Retired] Zanata Reporter: Sean Flanigan <sflaniga>
Component: Component-UIAssignee: Sean Flanigan <sflaniga>
Status: CLOSED CURRENTRELEASE QA Contact: Alex Eng <aeng>
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: aeng, hpeters, zanata-bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: 1.5.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-03-07 00:07:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 786670    

Description Sean Flanigan 2011-03-25 01:18:53 UTC
Description of problem:
  Translation editor table shows changes which failed to save

Version-Release number of selected component (if applicable):
  latest (2011-03-24)

How reproducible:

Steps to Reproduce:
1. Launch translation editor against locale, say XY
2. As project maintainer, disable locale XY for that project
3. Try to save a translation using the XY editor

Actual results:
  Cell contents assume the value entered by the user

Expected results:
  Error message, cell contents keep old value

Additional info:

Comment 1 Sean Flanigan 2011-09-07 04:33:34 UTC
Assigning to Scrum product owner for prioritisation.

Comment 2 Sean Flanigan 2012-02-10 06:07:36 UTC
We should review the status of this one.

Comment 3 Ding-Yi Chen 2012-02-16 01:44:26 UTC
In Zanata version 1.5-SNAPSHOT (20120215-1342).

Problem still exists, translators can still translate if they keep the webtrans open on the time the locale disable. 
It looks as if they can still save with error "An unknown error occurred". But the save did not actually succeed.

Using bookmark can still visit the document page, but no message is listed.


Comment 4 Sean Flanigan 2012-02-28 02:10:03 UTC
I've made error messages more visible: https://github.com/zanata/zanata/commit/569d8b931651fab909129bc1a217044b4096bb91

and also made notifications stay visible until dismissed: https://github.com/zanata/zanata/commit/104ed4f010f8134fc380accbcea5adfae2f7b76d

Convincing the editor table not to show the unsaved changes will have to wait until we can overhaul or replace it.

Comment 5 Alex Eng 2012-02-28 03:10:08 UTC
VERIFIED on implementation on Comment 4 in Zanata version 1.5.0-alpha-3-SNAPSHOT (20120228-1154).

Comment 6 Sean Flanigan 2012-03-01 00:43:50 UTC
*** Bug 728415 has been marked as a duplicate of this bug. ***