Bug 690870

Summary: allow parens in a valid name
Product: Red Hat Enterprise Linux 6 Reporter: James M. Leddy <james.leddy>
Component: nss-pam-ldapdAssignee: Nalin Dahyabhai <nalin>
Status: CLOSED ERRATA QA Contact: Ondrej Moriš <omoris>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.0CC: arthur, borgan, dpal, gborsuk, omoris, prc, syeghiay
Target Milestone: rcKeywords: Regression
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: nss-pam-ldapd-0.7.5-5.el6 Doc Type: Bug Fix
Doc Text:
Prior to this update, nslcd did not allow parentheses to be used in a valid name. With this update, the implementation of the "validusers" configuration option has been added and the use of opening and closing parentheses in usernames and groupnames is now allowed.
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-19 14:29:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
candidate backport + default tweak none

Description James M. Leddy 2011-03-25 16:32:03 UTC
Description of problem:

ldap checks more strictly in the isvalidname() routine. This attached patch allows paren characters in the name

--- nss-pam-ldapd-0.7.13/nslcd/common.c 2010-09-24 09:07:16.000000000 +0200
+++ nss-pam-ldapd-0.7.13.patched/nslcd/common.c 2011-03-24 08:52:38.000000000 +0100
@@ -105,7 +105,7 @@
              (name[i]>='@' && name[i] <= 'Z') ||
              (name[i]>='a' && name[i] <= 'z') ||
              (name[i]>='0' && name[i] <= '9') ||
-             name[i]=='.' || name[i]=='_'  || name[i]=='$' || name[i]==' ') )
+             name[i]=='.' || name[i]=='_'  || name[i]=='$' || name[i]==' ' || name[i]=='(' || name[i]==')') )
       return 0;
   }
   /* no test failed so it must be good */

Comment 8 Nalin Dahyabhai 2011-03-29 19:33:28 UTC
Created attachment 488536 [details]
candidate backport + default tweak

Comment 12 Martin Prpič 2011-04-28 08:24:57 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Prior to this update, nslcd did not allow parentheses to be used in a valid name. With this update, the implementation of the "validusers" configuration option has been added and the use of opening and closing parentheses in usernames and groupnames is now allowed.

Comment 13 errata-xmlrpc 2011-05-19 14:29:57 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0796.html