Bug 690882

Summary: Fix Coverity incorrect expression issues
Product: [Retired] 389 Reporter: Nathan Kinder <nkinder>
Component: Directory ServerAssignee: Nathan Kinder <nkinder>
Status: CLOSED CURRENTRELEASE QA Contact: Chandrasekar Kannan <ckannan>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 1.2.8CC: benl, rmeggins
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-17 14:08:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 639035, 708096    
Attachments:
Description Flags
Patch for cov#10571
nkinder: review?, rmeggins: review+
Patch for cov#10572,10710
rmeggins: review+
Patch for cov#10636,10637
nkinder: review?, rmeggins: review+
Patch for cov#10703
nkinder: review?, rmeggins: review+
Patch for cov#10572,10710 nkinder: review?, rmeggins: review+

Description Nathan Kinder 2011-03-25 17:00:09 UTC
A recent run of Coverity has identified a few incorrect expression issues.  We need to fix these issues.

Comment 1 Nathan Kinder 2011-03-25 17:03:05 UTC
Created attachment 487615 [details]
Patch for cov#10571

Comment 2 Nathan Kinder 2011-03-25 17:06:25 UTC
Created attachment 487617 [details]
Patch for cov#10572,10710

Comment 3 Nathan Kinder 2011-03-25 17:09:54 UTC
Created attachment 487619 [details]
Patch for cov#10636,10637

Comment 4 Nathan Kinder 2011-03-25 17:16:01 UTC
Created attachment 487621 [details]
Patch for cov#10703

Comment 5 Rich Megginson 2011-03-25 17:20:12 UTC
Comment on attachment 487617 [details]
Patch for cov#10572,10710

ugh - I hate magic numbers - but ok

Comment 6 Nathan Kinder 2011-03-25 17:42:30 UTC
Created attachment 487628 [details]
Patch for cov#10572,10710

Revised the previous patch to pass in the array length instead of using a magic number.

Comment 7 Nathan Kinder 2011-03-25 21:11:18 UTC
Pushed patches to master.  Thanks to Rich for his review!

Counting objects: 33, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (25/25), done.
Writing objects: 100% (25/25), 2.95 KiB, done.
Total 25 (delta 17), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
   13e53f4..5b6d116  master -> master