Bug 691226
Summary: | Review Request: perl-HTML-Form - Class that represents an HTML form element | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Emmanuel Seyman <emmanuel> |
Component: | Package Review | Assignee: | Iain Arnell <iarnell> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, lkundrak, notting |
Target Milestone: | --- | Flags: | iarnell:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-04-02 09:55:33 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Emmanuel Seyman
2011-03-27 16:37:09 UTC
There's a few requires that weren't automatically detected and need to be manually declared in the spec: perl(HTML::TokeParser) perl(HTTP::Request) >= 6 perl(HTTP::Request::Common) >= 6 But otherwise, a nice clean package. APPROVED. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2950823 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): 45fe6121ea15fbc3fad4ab6851d2dbf1c72971d1 HTML-Form-6.00.tar.gz 45fe6121ea15fbc3fad4ab6851d2dbf1c72971d1 HTML-Form-6.00.tar.gz.srpm Final provides / requires are sane: ======> perl-HTML-Form-6.00-1.fc16.noarch.rpm <====== ====> rpmlint perl-HTML-Form.noarch: W: spelling-error %description -l en_US UserAgent -> User Agent, User-agent, Superagency 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ====> provides perl(HTML::Form) = 6.00 perl-HTML-Form = 6.00-1.fc16 perl(HTML::Form::FileInput) perl(HTML::Form::IgnoreInput) perl(HTML::Form::ImageInput) perl(HTML::Form::Input) perl(HTML::Form::KeygenInput) perl(HTML::Form::ListInput) perl(HTML::Form::SubmitInput) perl(HTML::Form::TextInput) ====> requires perl(Carp) perl(Encode) perl(:MODULE_COMPAT_5.12.3) perl(strict) perl(URI) perl(vars) ====> obsoletes ====> conflicts ======> perl-HTML-Form-6.00-1.fc16.src.rpm <====== ====> rpmlint perl-HTML-Form.src: W: spelling-error %description -l en_US UserAgent -> User Agent, User-agent, Superagency 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ====> provides ====> requires perl(ExtUtils::MakeMaker) perl(HTML::TokeParser) perl(HTTP::Request) >= 6 perl(HTTP::Request::Common) >= 6 perl(Test::More) perl(URI) ====> obsoletes ====> conflicts ====> mock install INFO: mock.py version 1.1.9 starting... State Changed: init plugins INFO: selinux enabled State Changed: start Mock Version: 1.1.9 INFO: Mock Version: 1.1.9 State Changed: lock buildroot INFO: installing package(s): perl-HTML-Form-6.00-1.fc16.noarch.rpm INFO: ================================================================================ Package Arch Version Repository Size ================================================================================ Installing: perl-HTML-Form noarch 6.00-1.fc16 /perl-HTML-Form-6.00-1.fc16.noarch 63 k Installing for dependencies: perl-URI noarch 1.58-1.fc16 fedora 102 k Transaction Summary ================================================================================ Install 2 Package(s) Total size: 164 k Installed size: 249 k Installed: perl-HTML-Form.noarch 0:6.00-1.fc16 Dependency Installed: perl-URI.noarch 0:1.58-1.fc16 State Changed: unlock buildroot After you'll create this package, could you also rebuild WWW::Mechanize? It depends on this package. (In reply to comment #1) > > perl(HTML::TokeParser) > perl(HTTP::Request) >= 6 > perl(HTTP::Request::Common) >= 6 I've added these to the spec file. Spec URL: http://people.parinux.org/~seyman/fedora/perl-HTML-Form/perl-HTML-Form.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-HTML-Form/perl-HTML-Form-6.00-2.fc14.src.rpm > But otherwise, a nice clean package. APPROVED. Thanks, Ian. New Package SCM Request ======================= Package Name: perl-HTML-Form Short Description: Class that represents an HTML form element Owners: eseyman Branches: f14 f15 InitialCC: perl-sig (In reply to comment #2) > > After you'll create this package, could you also rebuild WWW::Mechanize? It > depends on this package. Will do. Git done (by process-git-requests). Imported and build on rawhide. (In reply to comment #2) > > After you'll create this package, could you also rebuild WWW::Mechanize? It > depends on this package. Done. Package Change Request
======================
Package Name: perl-HTML-Form
New Branches: epel7
Owners: lkundrak eseyman
> Emmanuel Seyman isn't an EPEL user and is happy for others to branch
> and build his packages, and they can add him as co-maintainer:
> https://bugzilla.redhat.com/show_bug.cgi?id=485897#c9
Git done (by process-git-requests). |