Bug 691376

Package: perl-Mozilla-CA
Version: 20110301
Release: 1.fc16
Sources: Mozilla-CA-20110301.tar.gz
Patches: 
----------
Package successfully built locally.
Package successfully built in mock, fedora-rawhide-x86_64.
Package successfully built in mock, fedora-rawhide-i386.
MUST items:
[  OK  ] Package does NOT include pre-built binaries or libraries
[  OK  ] Spec file is legible and written in American english
[  OK  ] Package successfully builds on at least one supported primary architecture
[  NA  ] All ExcludeArch tags valid, referencing proper bug reports
[  OK  ] Package obeys FHS (with _libexecdir and /srv exceptions)
[  OK  ] No errors reported by rpmlint
[  OK  ] Changelog present and properly formatted
[  OK  ] Package does NOT include Packager, Vendor, Copyright or PreReq tags
[  OK  ] Source tags are working URLs or justified otherwise
[ NOTE ] Requires correct or justified otherwise
[ NOTE ] BuildRequires correct or justified otherwise
[  OK  ] All file names are in proper UTF-8 encoding
[  OK  ] All plain text failes are in proper UTF-8 encoding
[  NA  ] Large documentation files are located in doc subpackage
[  OK  ] All documentation prefixed with %doc
[  OK  ] Documentation is NOT executable
[  OK  ] No files in %doc are needed at run-time
[  NA  ] Compiler flags honor Fedora defaults or are justified
[  NA  ] Package generates useful debuginfo packages
[  NA  ] Header files are placed in devel subpackage
[  NA  ] Unversioned shared libraries are placed in devel subpackage
[  NA  ] Pkgconfig files are placed in devel subpackage
[  NA  ] Full-versioned Requires of the base package in subpackages
[  NA  ] Package calls ldconfig in post and postun sections for all subpackages, if applicable
[  NA  ] Static libraries are provided by static subpackage
[  OK  ] Package contains no static executables unless approved by FESCo
[  OK  ] Package does NOT bundle any system libraries
[  NA  ] RPath not used for anything besides internal libraries
[  NA  ] All config files are marked noreplace or justified otherwise
[  OK  ] No config files are located under /usr
[  NA  ] Package contains a SystemV-compatible initscript
[  NA  ] A GUI application installs a proper desktop file
[  NA  ] All desktop files are installed by desktop-file-install or justified otherwise
[  OK  ] Package consistently uses macros
[  NA  ] makeinstall macro is used only if make install DESTDIR=%{buildroot} does NOT work
[  NA  ] Macros in Summary and description are expandable at build-time
[  NA  ] globals used in place of defines
[  NA  ] Locales handled correctly -- package requires gettext and uses find_lang, if applicable
[  NA  ] Scriptlets are sane
[  OK  ] Package is not relocatable unless justified
[  OK  ] Package contains only acceptable code or content
[  OK  ] Package owns all the files and directories it creates, installs and/or uses unless those are already owned by another package
[  OK  ] files sections do NOT contain duplicate files except for licenses
[  OK  ] All files sections use defattr or justify otherwise
[  OK  ] Package does NOT cause any conflicts
[  OK  ] Package does NOT contain kernel modules
[  OK  ] Package does NOT bundle fonts or other general purpose data
[  OK  ] Final Requires and Provides are sane

SHOULD items:
[  OK  ] The Summary does NOT end with a period
[  OK  ] Package does NOT include BuildRoot tag, clean section or buildroot removal in install section
[  OK  ] Package does NOT explicitly BuildRequire bash, bzip2, coreutils, cpio, diffutils, fedora-release, findutils, gawk, gcc, gcc-c++, grep, gzip, info, make, patch, redhat-rpm-config, rpm-build, sed, shadow-utils, tar, unzip, util-linux-ng, which or xz
[  OK  ] Description does NOT consist of lines longer than 80 characters
[  OK  ] Package should preserve files timestamps
[  OK  ] Package uses parallel make
[  NA  ] In case of a web application, package installs date into /usr/share instead of /var/www
[  NA  ] All patches have a comment or an upstream bug link
[  NA  ] Package installs manpages for all executables
[  OK  ] Package contains check section and all tests pass

Notes:
----------
Package should (build)require Cwd, File::BaseName and File::Spec

Updated package on the same URLs.

--- perl-Mozilla-CA.spec        2011-03-28 13:50:08.000000000 +0200
+++ perl-Mozilla-CA.spec.new    2011-03-28 16:19:38.000000000 +0200
@@ -8,6 +8,11 @@
 Source0:        http://www.cpan.org/authors/id/A/AB/ABH/Mozilla-CA-%{version}.tar.gz
 BuildArch:      noarch
 BuildRequires:  perl(ExtUtils::MakeMaker)
+# Tests:
+BuildRequires:  perl(Cwd)
+BuildRequires:  perl(File::Spec)
+BuildRequires:  perl(File::Basename)
+BuildRequires:  perl(Test)
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 
 %description

--
Approving.

New Package SCM Request
=======================
Package Name: perl-Mozilla-CA
Short Description: Mozilla's CA cert bundle in PEM format
Owners: ppisar, mmaslano, psabata
Branches: 
InitialCC: perl-sig

Git done (by process-git-requests).

Thank you for the review and the repository.