| Summary: | Review Request: perl-IO-Stty - Change and print terminal line settings | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marcela Mašláňová <mmaslano> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora-package-review, mcermak, notting, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-03-29 12:42:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Marcela Mašláňová
2011-03-28 13:03:09 UTC
Source file is original. Ok.
TODO: Change Summary to more descriptive text. E.g. the one from NAME perldoc section.
License verified from lib/IO/Stty.pm. Ok.
Description verified from lib/IO/Stty.pm. Ok.
No C binding, BuildArch Ok.
TODO: BuildRequire perl(POSIX) for tests (lib/IO/Stty.pm:6).
Minimal versions of Module::Build, Pod::Coverage, Test::Pod, Test::Pod::Coverage are provided by all Fedoras. Version can be left out. Ok.
Build time dependencies Ok.
All tests pass. Ok.
$ rpmlint perl-IO-Stty.spec ../SRPMS/perl-IO-Stty-0.03-1.fc14.src.rpm ../RPMS/noarch/perl-IO-Stty-0.03-1.fc14.noarch.rpm
perl-IO-Stty.noarch: W: no-manual-page-for-binary stty.pl
2 packages and 1 specfiles checked; 0 errors, 1 warnings.
rpmlint Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-IO-Stty-0.03-1.fc14.noarch.rpm
-rwxr-xr-x 1 root root 273 bře 28 15:35 /usr/bin/stty.pl
drwxr-xr-x 2 root root 0 bře 28 15:35 /usr/share/doc/perl-IO-Stty-0.03
-rw-r--r-- 1 root root 234 kvě 6 2010 /usr/share/doc/perl-IO-Stty-0.03/Changes
-rw-r--r-- 1 root root 7271 kvě 6 2010 /usr/share/doc/perl-IO-Stty-0.03/README
-rw-r--r-- 1 root root 4908 bře 28 15:35 /usr/share/man/man3/IO::Stty.3pm.gz
drwxr-xr-x 2 root root 0 bře 28 15:35 /usr/share/perl5/IO
-rw-r--r-- 1 root root 21085 bře 28 15:35 /usr/share/perl5/IO/Stty.pm
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-IO-Stty-0.03-1.fc14.noarch.rpm |sort |uniq -c
1 perl(IO::Stty)
1 perl(:MODULE_COMPAT_5.12.3)
1 perl(POSIX)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
1 /usr/bin/perl
Binary requires Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-IO-Stty-0.03-1.fc14.noarch.rpm |sort |uniq -c
1 perl(IO::Stty)
1 perl-IO-Stty = 0.03-1.fc14
TODO: Inject module version to perl(IO:Stty) Provides as stated in META.yml and lib/IO/Stty.pm:8.
$ resolvedeps-f16 ../RPMS/noarch/perl-IO-Stty-0.03-1.fc14.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F16 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2953758). Ok.
Package is in line with Fedora and perl packaging guidelines.
Please consider fixing all `TODO' prefixed issues before import package into repository.
Resolution: Package APPROVED.
New Package SCM Request ======================= Package Name: perl-IO-Stty Short Description: Change and print terminal line settings Owners: mmaslano ppisar psabata Branches: InitialCC: perl-sig Git done (by process-git-requests). Perfect, thanks for the package addition. It works nicely :-) Package Change Request ====================== Package Name: perl-IO-Stty New Branches: el5 el6 Owners: mmaslano InitialCC: perl-sig Git done (by process-git-requests). Package Change Request ====================== Package Name: perl-IO-Stty New Branches: f15 Owners: mmaslano InitialCC: perl-sig Git done (by process-git-requests). Package Change Request ====================== Package Name: perl-IO-Stty New Branches: f14 Owners: mmaslano InitialCC: perl-sig Git done (by process-git-requests). |