| Summary: | Fix Coverity error handling issues | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] 389 | Reporter: | Nathan Kinder <nkinder> | ||||||||||
| Component: | Directory Server | Assignee: | Nathan Kinder <nkinder> | ||||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Chandrasekar Kannan <ckannan> | ||||||||||
| Severity: | unspecified | Docs Contact: | |||||||||||
| Priority: | high | ||||||||||||
| Version: | 1.2.8 | CC: | amsharma, benl | ||||||||||
| Target Milestone: | --- | ||||||||||||
| Target Release: | --- | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Whiteboard: | |||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||
| Doc Text: | Story Points: | --- | |||||||||||
| Clone Of: | Environment: | ||||||||||||
| Last Closed: | 2011-05-17 14:08:45 UTC | Type: | --- | ||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||
| Documentation: | --- | CRM: | |||||||||||
| Verified Versions: | Category: | --- | |||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
| Bug Depends On: | |||||||||||||
| Bug Blocks: | 690319 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Nathan Kinder
2011-03-28 20:53:17 UTC
Created attachment 488262 [details]
Patch for cov#10579
Created attachment 488270 [details]
Patch for cov#10577
Created attachment 488279 [details]
Patch for cov#10573
Created attachment 488280 [details]
Patch for cov#10575
Pushed patches to master. Thanks to Noriko for her reviews! Counting objects: 39, done. Delta compression using up to 2 threads. Compressing objects: 100% (27/27), done. Writing objects: 100% (27/27), 2.99 KiB, done. Total 27 (delta 19), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git d91cd63..03a6bb7 master -> master The patch for cov#10573 had an extra paren. Made the following change to fix it:
/*
* The requestor may be either the bind dn or a proxy dn
*/
- if ((proxyauth_get_dn( pb, &proxydn, &errtext ) == LDAP_SUCCESS) && ( proxydn != NULL )) {
+ if ((proxyauth_get_dn( pb, &proxydn, &errtext ) == LDAP_SUCCESS) && ( proxydn != NULL ))
{
requestor_sdn = slapi_sdn_new_dn_passin ( proxydn );
}
Pushed to master:
Counting objects: 13, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 659 bytes, done.
Total 7 (delta 5), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
03a6bb7..0699244 master -> master
Coverity Related, Can I request dev to please test this. |