Bug 691693

Summary:	systemtap.base/bench.exp: PASS->FAIL
Product:	Red Hat Enterprise Linux 6	Reporter:	Petr Muller <pmuller>
Component:	systemtap	Assignee:	Frank Ch. Eigler <fche>
Status:	CLOSED ERRATA	QA Contact:	qe-baseos-tools-bugs
Severity:	low	Docs Contact:
Priority:	low
Version:	6.1	CC:	dsmith, jeast, mjw, ohudlick
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	systemtap-1.4-6.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-05-19 13:55:00 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Muller 2011-03-29 09:35:07 UTC

Description of problem:
The RHEL6.1 candidate systemtap packages FAIL in systemtap.base/bench.exp testcase, while the 6.0.z systemtap PASSes here. 

Version-Release number of selected component (if applicable):
Environment:
kernel-2.6.32-122.el6
elfutils-0.152-1.el6
systemtap-testsuite-1.4-4.el6

Systemtap:
systemtap-1.2-11.el6_0 PASS
systemtap-1.4-4 FAIL

How reproducible:
always

Steps to Reproduce:
1. cd /usr/share/systemtap/testsuite/
2. make RUNTESTFLAGS=systemtap.base/bench.exp installcheck
3.
  
Actual results:
FAIL

Expected results:
PASS

Additional info:
The FAIL seems to be caused by the change of output, so it's perhaps just the testcase problem. Old systemtap's output was a bunch of lines in this format:

probe test.null (/usr/share/systemtap/testsuite/systemtap.base/bench.stp:12:45), hits: 40, cycles: 119min/127avg/168max

while new systemtap has 40 lines for each old one in this format:

begin, (/usr/share/systemtap/testsuite/systemtap.base/bench.stp:12:19), hits: 1, cycles: 147min/147avg/147max, from: begin from: repeat from: test.null

Comment 1 Petr Muller 2011-03-29 11:25:36 UTC

similar problem caused a PASS->FAIL transition for systemtap.base/skipped.exp:

 ERROR: Skipped too many probes, check MAXSKIPPED or try again with stap -t for more details.
 WARNING: Number of errors: 0, skipped probes: 101
 WARNING: Skipped due to global 'f' lock timeout: 101
-probe timer.profile (<input>:3:1), hits: 108, cycles: 287min/1210693avg/18669462max
+----- probe hit report: 
+timer.profile, (<input>:3:1), hits: 296, cycles: 266min/12296636avg/18672864max, from: timer.profile
 Pass 5: run failed.  Try again with another '--vp 00001' option.
-PASS: skip tracking (8 1 2 1)
-testcase /usr/share/systemtap/testsuite/systemtap.base/skipped.exp completed in 5 seconds
+FAIL: skip tracking (8 0 2 1)
+testcase /usr/share/systemtap/testsuite/systemtap.base/skipped.exp completed in 11 seconds

Comment 2 David Smith 2011-03-29 20:47:08 UTC

Those two tests hadn't been updated with changes to the probe timing report output changes.  Fixed in the following upstream commit (which will need to be backported):

24e979d6357fbf3742e182a5ca87f17002940d2e

<http://sources.redhat.com/git/gitweb.cgi?p=systemtap.git;a=patch;h=24e979d6357fbf3742e182a5ca87f17002940d2e>

Comment 3 RHEL Program Management 2011-04-04 01:54:34 UTC

Since RHEL 6.1 External Beta has begun, and this bug remains
unresolved, it has been rejected as it is not proposed as
exception or blocker.

Red Hat invites you to ask your support representative to
propose this request, if appropriate and relevant, in the
next release of Red Hat Enterprise Linux.

Comment 5 Frank Ch. Eigler 2011-04-06 15:08:43 UTC

Trivial test case hack in hand.

Comment 11 errata-xmlrpc 2011-05-19 13:55:00 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0651.html