Bug 691958

Created attachment 488606 [details]
Do not try to set vim's encoding option in a modeline

Description of problem:

ldapvi is hardcoded to insert a vim modeline into the text
it sends to your editor.  This modeline tries to set vim's
"encoding" option to "utf-8".

In July of last year, vim was changed to disallow setting the
"encoding" option in a modeline.  The reason this change
was made is that setting this option once a file has been
loaded may corrupt the existing text in the buffer.  You
can set the "fileencoding" option instead, which will affect
the encoding used when the file is written back out, but
there's no good reason for ldapvi to do that because if it
managed to select an incorrect encoding while loading the
file, the relevant data has been lost already.

Information about the relevant vim change may be found here:
http://code.google.com/p/vim/source/detail?r=2b2cd34569eb97cbdb5f6500436923d19fdf8fbd&path=/src/option.c

The version of vim including that change is now in Fedora,
and the result is that any time a non-root user runs ldapvi
with vim as their editor, they get an error before startup
telling them that setting "encoding" in a modeline isn't supported,
and there's no way for them to fix that (vim doesn't use
modelines when run as root).

A patch was offered to the ldapvi mailman list in January
to change to setting "fileencoding", and subsequently the list
agreed that ldapvi should simply not try to set any encoding
with vim.  You can see this discussion and the withdrawn patch
here:

http://lists.askja.de/pipermail/ldapvi/2011-January/000089.html

Unfortunately, the last ldapvi release was four years ago, and
the last commit to its repository is coming up on its two-year
anniversary.  Since no help appears to be forthcoming from
upstream, would you please consider applying the attached trivial
patch to ldapvi in Fedora so that users can stop getting the
annoying error every single time they use the program?

Thanks in advance!


Version-Release number of selected component (if applicable):
ldapvi-1.7-10.fc13

How reproducible:
100%

Steps to Reproduce:
1. With EDITOR/VISUAL set to 'vim', run ldapvi with a query
   that will return at least one record, as a non-root user.
  
Actual results:
"""Error detected while processing modelines:
line    1:
E520: Not allowed in a modeline: encoding=utf-8
"""