Bug 693202
Summary: | chkconfig S## prioritory set inconsistently for initscript with Requires-Start: $network | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> | ||||
Component: | chkconfig | Assignee: | Bill Nottingham <notting> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 15 | CC: | notting, rvokal | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | chkconfig-1.3.57-1.fc16 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | |||||||
: | 771455 (view as bug list) | Environment: | |||||
Last Closed: | 2011-05-03 04:54:13 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Hans de Goede
2011-04-03 14:10:18 UTC
p.s. I realize that having a "Requires-Start: $network" is not a good idea in general in a NetworkManager world, but that is a different discussion then the weird moving of the S## priority of tgtd without any valid reason. At what point did you enable tgtd.service, and in what environment? Hi, (In reply to comment #2) > At what point did you enable tgtd.service, and in what environment? I enabled and disabled it several times, all from a xterm under gnome-shell, so from a fully booted & logged in system. All invocations where done as: sudo systemctl enable foo resp: sudo systemctl disable foo When ever I enable tgtd it gets a S## priority of 11, as soon as I also enable either iscsid or iscsi (haven't tried with others) it gets moved to 24. Regards, Hans Is NM installed at all, and if so, is it disabled in all runlevels? I'm unable to reproduce your issue with NM disabled. I *am* able to reproduce it with NM enabled; it's only moved the second time it's operated on. Created attachment 490032 [details]
patch
The attached should fix the issue of it moving on subsequent chkconfig invocations.
The problem is that the dependency frobber for a specific service checks to make sure that the service is similarly configured to whatever is providing its dependencies. However, if you're enabling a disabled service, or disabling an enabled service, the states won't match initially.
This fixes it by setting the state on the filesystem before calling the dependency frobber. It's a bit of a hack, in that it means when doing enable/disable, you'll get the state set twice.
I've given the attached patch a try, and it indeed fixes the issue of the moving, tgtd now starts at position 24 and stays there. With this patch I'm seeing other ordering issues with the iscsi service though, recently the iscsi sysv init script has grown the following deps: Should-Start: tgtd Should-Stop: tgtd So that logging in to locally hosted iscsi targets works properly, this means it should be ordered after tgtd, but if I disable iscsi + tgtd then: 1) enable iscsi, gets position 13 2) enable tgtd gets pos 24, iscsi stays at position 13 Then enabling / disabling some other service (tried iscsid) moves iscsi to 25, but this should have happened as soon as tgtd was enabled... Will have to test that. Patch merged, will be in a future build. chkconfig-1.3.52-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/chkconfig-1.3.52-1.fc15 Package chkconfig-1.3.52-1.fc15: * should fix your issue, * was pushed to the Fedora 15 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing chkconfig-1.3.52-1.fc15' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/chkconfig-1.3.52-1.fc15 then log in and leave karma (feedback). chkconfig-1.3.52-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. I'm going to open a new bug for the issue described in comment #7 to make sure that that does not fall through the cracks. chkconfig-1.3.57-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/chkconfig-1.3.57-1.fc16 chkconfig-1.3.57-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. |