Bug 693306

Summary:	sfdisk's python interface only accepts lists of type 'list' for the lines parameter
Product:	Red Hat Enterprise Linux 6	Reporter:	Erez Shinan <erez>
Component:	libguestfs	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	low	Docs Contact:
Priority:	medium
Version:	6.1	CC:	jzheng, leiwang, smizrahi, syeghiay, yuzhang
Target Milestone:	rc	Keywords:	TestBlocker
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libguestfs-1.7.17-19.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	693324 (view as bug list)		Environment:
Last Closed:	2011-12-06 10:31:40 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	693324
Bug Blocks:

Description Erez Shinan 2011-04-04 09:50:34 UTC

Description of problem:
I'm using a network proxy to call libguestfs' python interface (specifically: rpyc), and sfdisk rejects its list look-alike

It can be solved very simply by changing the code like:
-       return libguestfsmod.sfdisk (self._o, device, cyls, heads, sectors, lines)
+       return libguestfsmod.sfdisk (self._o, device, cyls, heads, sectors, list(lines))

It won't affect existing code, and it will accept any iterable instead of throwing a RuntimeError.



Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 2 RHEL Program Management 2011-04-04 09:53:17 UTC

Since RHEL 6.1 External Beta has begun, and this bug remains
unresolved, it has been rejected as it is not proposed as
exception or blocker.

Red Hat invites you to ask your support representative to
propose this request, if appropriate and relevant, in the
next release of Red Hat Enterprise Linux.

Comment 3 Richard W.M. Jones 2011-04-04 11:49:37 UTC

Upstream commit:
http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=afa17809599f3ebc82c3feef025ca812fb26c9fe

Comment 7 Richard W.M. Jones 2011-04-11 08:33:14 UTC

dev-ack+ for 6.2.

Comment 8 Richard W.M. Jones 2011-04-11 10:17:56 UTC

QA are telling me in other bugs that they don't want to
do any more changes to libguestfs for 6.1.

Comment 9 Richard W.M. Jones 2011-07-04 16:50:18 UTC

https://brewweb.devel.redhat.com/taskinfo?taskID=3462253

Comment 11 Jinxin Zheng 2011-07-07 09:22:52 UTC

This is the reproducing python script:

$ cat sfdisk-test.py

import guestfs
g=guestfs.GuestFS()
g.add_drive('test.img')
g.launch()
trip=('1,100,83', '102,60,83', '200,50,83')
g.sfdisk('/dev/sda',0,0,0, trip)

$ truncate -s 1G test.img
$ python sfdisk-test.py

--
(outputs from libguestfs-1.7.17-17.el6)

Using CPU model "cpu64-rhel6"
Traceback (most recent call last):
  File "sfdisk.py", line 7, in <module>
    g.sfdisk('/dev/sda',0,0,0, trip)
  File "/usr/lib/python2.6/site-packages/guestfs.py", line 1684, in sfdisk
    return libguestfsmod.sfdisk (self._o, device, cyls, heads, sectors, lines)
RuntimeError: expecting a list parameter

--
(outputs from libguestfs-1.7.17-19.el6)

Using CPU model "cpu64-rhel6"
--

resulting part table layout of -19 can be verified with sfdisk_l using guestfish.

Comment 12 errata-xmlrpc 2011-12-06 10:31:40 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1512.html