Bug 693761
| Summary: | Review Request: php-Kohana - The Swift PHP Framework | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gwyn Ciesla <gwync> |
| Component: | Package Review | Assignee: | Matthias Runge <mrunge> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora-package-review, mrunge, notting |
| Target Milestone: | --- | Flags: | mrunge:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | php-Kohana-2.4-1.rc2.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-10-04 21:18:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 693820 | ||
|
Description
Gwyn Ciesla
2011-04-05 14:20:15 UTC
I'll do a review tomorrow. Package Review
==============
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format %{name}.spec.
[x] Package meets the Packaging Guidelines.
[x] Package successfully compiles and builds into binary rpms on at least one supported architecture.
Tested on: noarch
[x] Rpmlint output: (clean)
[x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: BSD
[x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided in the spec URL.
MD5SUM this package : 32e4729c4f2fc12d206c8a8220f9e463
MD5SUM upstream package: 32e4729c4f2fc12d206c8a8220f9e463
[x] Package is not known to require ExcludeArch, OR:
Arches excluded:
Why:
[x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[-] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI application.
[-] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[-] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[x] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3369211
[x] Package should compile and build into binary rpms on all supported architectures.
Tested on: noarch
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files are correct.
[-] File based requires are sane.
Side note: Definition of buildroot is not required any more.
================
*** APPROVED ***
================
Noted, thanks very much! New Package SCM Request ======================= Package Name: php-Kohana Short Description: The Swift PHP Framework Owners: limb Branches: f15 f16 EL-6 InitialCC: Git done (by process-git-requests). php-Kohana-2.4-1.rc2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/php-Kohana-2.4-1.rc2.fc15 php-Kohana-2.4-1.rc2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-Kohana-2.4-1.rc2.el6 php-Kohana-2.4-1.rc2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/php-Kohana-2.4-1.rc2.fc16 php-Kohana-2.4-1.rc2.fc16 has been pushed to the Fedora 16 testing repository. php-Kohana-2.4-1.rc2.fc16 has been pushed to the Fedora 16 stable repository. php-Kohana-2.4-1.rc2.fc15 has been pushed to the Fedora 15 stable repository. php-Kohana-2.4-1.rc2.el6 has been pushed to the Fedora EPEL 6 stable repository. |