Bug 694215

Summary: support storage_init=<bus> in dracut plugin
Product: Red Hat Enterprise Linux 6 Reporter: Chris Pelland <cpelland>
Component: ovirt-nodeAssignee: Mike Burns <mburns>
Status: CLOSED CURRENTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 6.1CC: apevec, gouyang, jpallich, leiwang, mburns, moli, ovirt-maint, pm-eus, ycui
Target Milestone: rcKeywords: ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-node-1.9.3-15.10.el6_0.1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-09-20 11:25:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 691891    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
debug log
none
autoinstall with usb fail serial output
none
autoinstall with scsi fail on local disk outputs from serial none

Description Chris Pelland 2011-04-06 18:23:20 UTC
This bug has been copied from bug #691891 and has been proposed
to be backported to 6.0 z-stream (EUS).

Comment 3 Mike Burns 2011-04-06 20:17:28 UTC
Created attachment 490380 [details]
Patch

Comment 5 Mohua Li 2011-04-11 06:09:42 UTC
as this bug is clone from 6.1, but we all know that we don't need to support cciss in 6.0.z(bug 691687), i'm not sure what should be really test for this bug, storage_init=scsi:serialnumber?

Comment 6 Mike Burns 2011-04-11 12:11:31 UTC
you can test with scsi, scsi:serialnumber, usb, ata, etc.  Anything you can specify in storage_init for installation purposes should now be supported for the dracut cleanup plugin

Comment 7 Mohua Li 2011-04-14 09:18:30 UTC
rhevh 6.0-15.9.1, 


auto install with storage_init=cciss, storage_init=scsi(only one local stat disk), still fail as "Device specified in storage_init does not exist",

Comment 8 Mike Burns 2011-04-18 18:24:48 UTC
Created attachment 492977 [details]
Patch

Comment 9 Guohua Ouyang 2011-04-19 03:24:35 UTC
Verified on 6.0.15.10.1:
1. on cciss machine:
storage_init=cciss fails
storage_init=scsi works

2. on local disk machine:
storage_init=ata work
storage_init=scsi fails
storage_init=usb fails.

the root cause is that find_disk function not work with all these parameters:
1. on cciss machine:
[root@dhcp-66-73-189 libexec]# . ovirt-boot-functions
[root@dhcp-66-73-189 libexec]# find_disk cciss
[root@dhcp-66-73-189 libexec]# find_disk scsi
/dev/sda


2. on local disk machine:
[root@localhost libexec]#. ovirt-boot-functions
[root@localhost libexec]# find_disk ata
/dev/sda
[root@localhost libexec]# find_disk scsi
[root@localhost libexec]# find_disk usb

Attached the debug process and log below.

Comment 10 Guohua Ouyang 2011-04-19 03:52:55 UTC
Created attachment 493065 [details]
debug log

cciss* does not exist under /dev/disk/by-id/, so find_disk fail to find cciss
scsi* exist under /dev/disk/by-id/
udev_info /dev/sda property 
$ID_BUS=scsi, ok
$ID_FS_USAGE does not exist, so find_disk can find scsi

ata*, scsi*, usb* exists under /dev/disk/by-id/
for ata/scsi, udev_info /dev/sda property 
$ID_BUS=ata, ok, can only find ata, scsi will fail
$ID_FS_USAGE does not exist, so can find ata.

for usb, udev_info /dev/sdb property 
$ID_BUS=usb, OK
$ID_FS_USAGE exist, so cannot find usb

Comment 11 Guohua Ouyang 2011-04-19 03:54:10 UTC
Created attachment 493066 [details]
autoinstall with usb fail serial output

Comment 12 Guohua Ouyang 2011-04-19 03:55:02 UTC
Created attachment 493067 [details]
autoinstall with scsi fail on local disk outputs from serial

Comment 13 Guohua Ouyang 2011-04-19 06:39:26 UTC
test with a usb disk have no any filesystem, storage_init=usb works.

Comment 14 Alan Pevec 2011-04-19 11:13:06 UTC
(In reply to comment #9)
> 1. on cciss machine:
> storage_init=cciss fails
> storage_init=scsi works

As explained in bug 691891 comment 17, some cciss controllers use hpsa which is normal scsi driver, so this result is expected.
I'm just not sure how to explain this to users...

> 2. on local disk machine:
> storage_init=ata work
> storage_init=scsi fails
> storage_init=usb fails.

ata is expected for local sata drive

Comment 15 Alan Pevec 2011-04-19 11:18:38 UTC
(In reply to comment #10)
> for usb, udev_info /dev/sdb property 
> $ID_BUS=usb, OK
> $ID_FS_USAGE exist, so cannot find usb

That's the only remaining issue: how is this USB stick formatted?
Seems to be w/o partition table i.e. filesystem directly on disk device?
If so, please file separate BZ to handle this case in 6.2/6.1.z it's not a blocker, we can have a relnote for this.

Comment 16 Guohua Ouyang 2011-04-20 10:39:21 UTC
close this bug as a separate bug 698158 have been reported for usb problem.