Bug 694216

Summary: include livecd-iso-to-* scripts in rhev-hypervisor RPM
Product: Red Hat Enterprise Linux 6 Reporter: Chris Pelland <cpelland>
Component: rhev-hypervisor6Assignee: Mike Burns <mburns>
Status: CLOSED CURRENTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 6.1CC: apevec, gouyang, jboggs, leiwang, mburns, moli, mshao, ovirt-maint, pm-eus, ycui, yeylon
Target Milestone: rcKeywords: ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rhev-hypervisor-6.0-15.9.el6_0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-11-04 20:24:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 691832    
Bug Blocks:    

Description Chris Pelland 2011-04-06 18:24:09 UTC
This bug has been copied from bug #691832 and has been proposed
to be backported to 6.0 z-stream (EUS).

Comment 3 Mike Burns 2011-04-06 20:13:30 UTC
Add edit-livecd and livecd-iso-to* scripts to rpm.  For patch details, see bug 691832

Comment 5 Mohua Li 2011-04-11 06:29:50 UTC

[root@dhcp-93-131 ~]# rpm -ql rhev-hypervisor-6.0-15.9.el6_0.noarch
/usr/bin/edit-rhevh
/usr/bin/rhevh-iso-to-disk
/usr/bin/rhevh-iso-to-pxeboot
/usr/share/rhev-hypervisor/rhev-hypervisor.iso

Comment 6 Mohua Li 2011-04-11 06:36:07 UTC
but the name is changed, is this expected?

Comment 7 Mohua Li 2011-04-11 06:38:12 UTC
but the name is changed, is this expected, and it's not in executable, i think we need to fix this, 


[root@dhcp-93-131 ~]# ls  /usr/bin/rhevh-iso-to-disk
/usr/bin/rhevh-iso-to-disk
[root@dhcp-93-131 ~]# /usr/bin/rhevh-iso-to-disk
bash: /usr/bin/rhevh-iso-to-disk: Permission denied
[root@dhcp-93-131 ~]# chmod 755 /usr/bin/rhevh-iso-to-disk
[root@dhcp-93-131 ~]# /usr/bin/rhevh-iso-to-disk

Comment 8 Mike Burns 2011-04-11 12:37:51 UTC
Name change is required.  If we don't change the name, then it will conflict with livecd-tools which is not something we want to do.  

livecd-iso-to-pxeboot --> rhevh-iso-to-pxeboot
livecd-iso-to-disk --> rhevh-iso-to-disk
edit-livecd --> edit-rhevh

As for permissions, yes, they should be executable by default.  The fix is easy to do as well.

Comment 9 Mike Burns 2011-04-11 12:38:29 UTC
--- rhev-hypervisor.spec 7 Apr 2011 15:33:09 -0000 1.31
+++ rhev-hypervisor.spec 11 Apr 2011 12:36:53 -0000
@@ -71,11 +71,16 @@
 %files
 %defattr(0644,root,root,0755)
 %{app_root}/%{name}.iso
+%defattr(0755,root,root,0755)
 %{_bindir}/rhevh-iso-to-pxeboot
 %{_bindir}/rhevh-iso-to-disk
 %{_bindir}/edit-rhevh

Comment 12 Guohua Ouyang 2011-04-20 06:39:12 UTC
Verified on 6.0-15.10.1,  bug is fixed

# rpm -ivh /home/guohua/Downloads/rhev-hypervisor-6.0-15.10.1.el6_0.noarch.rpm 
Preparing...                ########################################### [100%]
   1:rhev-hypervisor        ########################################### [100%]
]# ll /usr/bin/rhevh-iso-to-*
-rwxr-xr-x. 1 root root 23040 Apr  7 04:12 /usr/bin/rhevh-iso-to-disk
-rwxr-xr-x. 1 root root  3889 Apr  7 04:12 /usr/bin/rhevh-iso-to-pxeboot
[root@avatar ~]# ll /usr/bin/edit-rhevh 
-rwxr-xr-x. 1 root root 12054 Apr  8 20:47 /usr/bin/edit-rhevh

# rpm -ql rhev-hypervisor-6.0-15.10.1.el6_0.noarch
/usr/bin/edit-rhevh
/usr/bin/rhevh-iso-to-disk
/usr/bin/rhevh-iso-to-pxeboot
/usr/share/rhev-hypervisor/rhev-hypervisor.iso