Bug 694568
| Summary: | Review Request: python-testtools - Extensions to the Python unit testing framework | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> |
| Component: | Package Review | Assignee: | Toshio Ernie Kuratomi <a.badger> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | a.badger, fedora-package-review, jbresnah, notting |
| Target Milestone: | --- | Flags: | a.badger:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-testtools-0.9.8-2.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-04-16 20:51:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michel Lind
2011-04-07 16:29:34 UTC
* rpmlint: python-testtools.noarch: W: non-standard-group Unspecified python-testtools.src: W: non-standard-group Unspecified python-testtools.src:35: E: files-attr-not-set python-testtools.src:36: E: files-attr-not-set These are all from the same source: we need a %defattr(-, root, root, -) line in %files. * Name follows Guidelines * License is good and included * Spec is legible * Source matches upstream * Package builds in koji * No locale files * No bundled system libraries * Not relocatable * All files and directories are owned * Macros used consistently * Code not content * No large doc * documentation doesn't affect runtime * Not a dynamic library * Not a GUI app Nit: It's better to BuildRequires: python2-devel rather than python-devel As long as you add the %defattr before importing, this is APPROVED. The missing group and attributes are due to those being deprecated in RPM >= 4.9 (and thus rpmdev-newspec does not provide those fields on F-15+). Will re-add because we do want to make this available on F-14 and probably even EPEL. Thanks! New Package SCM Request ======================= Package Name: python-testtools Short Description: Extensions to the Python unit testing framework Owners: salimma Branches: f14 f15 el6 InitialCC: Git done (by process-git-requests). python-testtools-0.9.8-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/python-testtools-0.9.8-2.fc14 python-testtools-0.9.8-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-testtools-0.9.8-2.el6 python-testtools-0.9.8-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/python-testtools-0.9.8-2.fc15 python-testtools-0.9.8-2.el6 has been pushed to the Fedora EPEL 6 testing repository. python-testtools-0.9.8-2.fc14 has been pushed to the Fedora 14 stable repository. python-testtools-0.9.8-2.fc15 has been pushed to the Fedora 15 stable repository. python-testtools-0.9.8-2.el6 has been pushed to the Fedora EPEL 6 stable repository. *** Bug 907665 has been marked as a duplicate of this bug. *** |