Bug 694585

Hi,

I planned package also the GS extensions, but you were faster :).
Shouldn't the version be 3.0.0, since the commit you use is based on the 3.0.0 tag?

Yep. I should package that version instead of a snapshot I think.  Working on it and you are welcome as a co-maintainer.

Updated spec to fix version.  Added intltool as BR.  Working on sub packages

Done.  Should be ready for review now.  

http://sundaram.fedorapeople.org/packages/gnome-shell-extensions.spec
http://sundaram.fedorapeople.org/packages/gnome-shell-extensions-3.0.0-0.6d56cfgit.fc15.src.rpm

(In reply to comment #2)
> Yep. I should package that version instead of a snapshot I think.  Working on
> it and you are welcome as a co-maintainer.
I'd be glad to comaintain this package... And to review it :)

Ok.   Go ahead then.

./autogen.sh calls gnome-autogen.sh, which launches the ./configure script generated before. To avoid ./configure being run twice (once from ./autogen.sh, once by %configure), you can set NOCONFIGURE to 1: it will prevent gnome-autogen.sh from launching ./configure:

%build
# since we build from a git checkout
NOCONFIGURE=1 ./autogen.sh  --enable-extensions="alternate-tab alternative-status-menu dock windowsNavigator"
%configure
make %{?_smp_mflags}

Using subpackages for each extension is a great idea. Once the little issue above fixed, I will approve this package :)

(In reply to comment #0)
> I have enabled only some extensions because the rest don't work for me.
Same issues here, especially with the user theme extension. I'm still trying to understand why ^^.

Fixed to not call configure twice.  

http://sundaram.fedorapeople.org/packages/gnome-shell-extensions.spec
http://sundaram.fedorapeople.org/packages/gnome-shell-extensions-3.0.0-1.6d56cfgit.fc15.src.rpm

We can incrementally enable extensions once we can get them working.  That's why I introduced sub packages.  Users have the flexibility to pick and choose what they want as well.

Ping? Made the only change you wanted

Don't be so impatient, I've just coming back from work ^^.

Here is the review:

MUST: rpmlint must be run on every package.
->OK, no significative warning/error

MUST: The package must be named according to the Package Naming Guidelines.
->OK

MUST: The spec file name must match the base package %{name}, in the format
      %{name}.spec unless your package has an exemption.
->OK

MUST: The package must meet the Packaging Guidelines.
->OK

MUST: The package must be licensed with a Fedora approved license and meet the
      Licensing Guidelines.
->OK

MUST: The License field in the package spec file must match the actual license.
->OK, all files under GPL v2 or above

MUST: If (and only if) the source package includes the text of the license(s) in
      its own file, then that file, containing the text of the license(s) for
      the package must be included in %doc.
->N/A

MUST: The spec file must be written in American English.
->OK

MUST: The spec file for the package MUST be legible.
->OK

MUST: The sources used to build the package must match the upstream source, as
      provided in the spec URL.
->N/A

MUST: The package MUST successfully compile and build into binary rpms on at
      least one primary architecture.
->OK, see http://koji.fedoraproject.org/koji/taskinfo?taskID=2984258

MUST: If the package does not successfully compile, build or work on an
      architecture, then those architectures should be listed in the spec in
      ExcludeArch.
->N/A

MUST: All build dependencies must be listed in BuildRequires, except for any
      that are listed in the exceptions section of the Packaging Guidelines ;
      inclusion of those as BuildRequires is optional.
->OK

MUST: The spec file MUST handle locales properly. This is done by using the
      %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
->OK

MUST: Every binary RPM package (or subpackage) which stores shared library files
      (not just symlinks) in any of the dynamic linker's default paths, must
      call ldconfig in %post and %postun.
->N/A

MUST: Packages must NOT bundle copies of system libraries.
->OK

MUST: If the package is designed to be relocatable, the packager must state this
      fact in the request for review, along with the rationalization for
      relocation of that specific package. Without this, use of Prefix: /usr is
      considered a blocker.
->N/A

MUST: A package must own all directories that it creates. If it does not create
      a directory that it uses, then it should require a package which does
      create that directory.
>OK

MUST: A Fedora package must not list a file more than once in the spec file's
      %files listings. 
->OK

MUST: Permissions on files must be set properly. Executables should be set with
      executable permissions, for example. Every %files section must include a
      %defattr(...) line.
->OK

MUST: Each package must consistently use macros.
->OK

MUST: The package must contain code, or permissable content.
->OK

MUST: Large documentation files must go in a -doc subpackage.
->N/A

MUST: If a package includes something as %doc, it must not affect the runtime of
      the application. To summarize: If it is in %doc, the program must run
      properly if it is not present.
->OK

MUST: Header files must be in a -devel package.
->N/A

MUST: Static libraries must be in a -static package.
->N/A

MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
      then library files that end in .so (without suffix) must go in a -devel
      package.
->N/A

MUST: In the vast majority of cases, devel packages must require the base
      package using a fully versioned dependency: Requires: %{name} =
      %{version}-%{release}.
->N/A

MUST: Packages must NOT contain any .la libtool archives, these must be removed
      in the spec if they are built.
->N/A

MUST: Packages containing GUI applications must include a %{name}.desktop file,
      and that file must be properly installed with desktop-file-install in the
      %install section.
->N/A

MUST: Packages must not own files or directories already owned by other
      packages.
->OK

MUST: All filenames in rpm packages must be valid UTF-8.
->OK

This package is APPROVED.

Thanks.  I can't find out your fas account name.  Apply after I import.  

New Package SCM Request
=======================
Package Name: gnome-shell-extensions
Short Description: Modify and extend GNOME Shell functionality and behavior
Owners: sundaram 
Branches: f15
InitialCC:

Git done (by process-git-requests).

https://admin.fedoraproject.org/updates/gnome-shell-extensions-3.0.0-1.6d56cfgit.fc15