| Summary: | Review Request: perl-Devel-Trace - Print out each line before it is executed (like sh -x) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mathieu Bridon <bochecha> |
| Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-04-26 10:09:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Mathieu Bridon
2011-04-08 02:56:12 UTC
(In reply to comment #0) > SPEC: http://bochecha.fedorapeople.org/packages/perl-Devel-Trace.spec > SRPM: > http://bochecha.fedorapeople.org/packages/perl-Devel-Trace-0.10-1.el6.src.rpm Wrong URL for the SRPM (I had prepared this review request some time ago and forgot to correct it when I actually posted it). SPEC: http://bochecha.fedorapeople.org/packages/perl-Devel-Trace.spec SRPM: http://bochecha.fedorapeople.org/packages/perl-Devel-Trace-0.11-1.fc15.src.rpm Sorry for the noise. :-/ - rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
http://koji.fedoraproject.org/koji/taskinfo?taskID=3015453
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK
rpm -qp --provides ../RPMS/noarch/perl-Devel-Trace-0.11-1.fc14.noarch.rpm
perl(Devel::Trace) = 0.11
perl-Devel-Trace = 0.11-1.fc14
rpm -qp --requires ../RPMS/noarch/perl-Devel-Trace-0.11-1.fc14.noarch.rpm
perl(:MODULE_COMPAT_5.12.3)
perl(Carp)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
APPROVED
New Package SCM Request ======================= Package Name: perl-Devel-Trace Short Description: Print out each line before it is executed (like sh -x) Owners: bochecha Branches: f15 el6 InitialCC: perl-sig Git done (by process-git-requests). Package was imported and built in all requested branches. Thank you Marcela for the review and Jason for handling the VCS. |