Bug 694706

Created attachment 490692 [details]
Core file

Description of problem:
When testing Bug 694702, I tried to scan the bad image using xfs_repair with -n option(no modify mode), but xfs_repair got segfault.

[root@ibm-x3550m3-02 ~]# xfs_repair -nf -o force_geometry xfs.test.img
Phase 1 - find and verify superblock...
Phase 2 - using internal log
        - scan filesystem freespace and inode maps...
agi unlinked bucket 10 is 4294945279 in ag 0 (inode=4294945279)
primary/secondary superblock 1 conflict - AG superblock geometry info conflicts with filesystem geometry
would reset bad sb for ag 1
bad uncorrected agheader 1, skipping ag...
sb_fdblocks 27887, counted 14580
        - found root inode chunk
Phase 3 - for each AG... 
        - scan (but don't clear) agi unlinked lists...
error following ag 0 unlinked list
error following ag 1 unlinked list
        - process known inodes and perform inode discovery...
        - agno = 0
bad magic number 0x49f7 on inode 95
bad magic number 0xbe4e on inode 110
entry "config.log" at block 0 offset 192 in directory inode 64 references invalid inode 182518930210889
        would clear inode number in entry at offset 192...
bad non-zero extent size 33024 for non-realtime/extsize inode 71, would reset to zero
bad attr fork offset 142 in inode 73, max=19
would have cleared inode 73
bad extent #0 count (31) in symlink 74 data fork
bad data fork in symlink 74
would have cleared inode 74
bad nblocks 957777707213 for inode 88, would reset to 205
bad nblocks 14417942 for inode 92, would reset to 22
would have corrected attribute entry count in inode 93 from 79 to 1
bad magic number 0x49f7 on inode 95, would reset magic number
would have cleared inode 95
bad nblocks 93458488360960 for inode 103, would reset to 0
bad magic number 0xbe4e on inode 110, would reset magic number
        - agno = 1
        - process newly discovered inodes...
Phase 4 - check for duplicate blocks...
        - setting up duplicate extent list...
        - check for inodes claiming duplicate blocks...
        - agno = 0
        - agno = 1
entry "config.log" at block 0 offset 192 in directory inode 64 references invalid inode 182518930210889
        would clear inode number in entry at offset 192...
entry "config.status" at block 0 offset 216 in directory inode 64 references free inode 74
        would clear inode number in entry at offset 216...
bad non-zero extent size 33024 for non-realtime/extsize inode 71, would reset to zero
bad attr fork offset 142 in inode 73, max=19
would have cleared inode 73
bad extent #0 count (31) in symlink 74 data fork
bad data fork in symlink 74
would have cleared inode 74
bad nblocks 957777707213 for inode 88, would reset to 205
bad nblocks 14417942 for inode 92, would reset to 22
bad magic number 0x49f7 on inode 95, would reset magic number
would have cleared inode 95
bad nblocks 93458488360960 for inode 103, would reset to 0
bad magic number 0xbe4e on inode 110, would reset magic number
No modify flag set, skipping phase 5
Phase 6 - check inode connectivity...
        - traversing filesystem ...
Segmentation fault (core dumped)

If run xfs_repair without -n option, the image can be fixed successfully.


Version-Release number of selected component (if applicable):
xfsprogs-qa-devel-3.1.1-4.el6.x86_64
xfsprogs-3.1.1-4.el6.x86_64
xfsprogs-debuginfo-3.1.1-4.el6.x86_64
xfsprogs-devel-3.1.1-4.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Download bad image from Bug 694702
2. xfs_repair -nf -o force_geometry xfs.test.img
  
Actual results:
core dump

Expected results:
No segfault

Additional info: