Bug 694835

Summary: wrong return code of condor_configure_store/pool
Product: Red Hat Enterprise MRG Reporter: Lubos Trilety <ltrilety>
Component: condor-wallaby-toolsAssignee: Robert Rati <rrati>
Status: CLOSED ERRATA QA Contact: Lubos Trilety <ltrilety>
Severity: low Docs Contact:
Priority: low    
Version: betaCC: iboverma, jneedle, matt, rrati
Target Milestone: 2.0   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: condor-wallaby-tools-4.0-6 Doc Type: Bug Fix
Doc Text:
C: Providing invalid arguments, or other invalid scenarios, to the condor_configure_pool/store tools C: The tools would indicate error, but the return value would indicate success F: The tools properly exit with an non-zero value in error cases R: The tools will return non-zero return codes when the actions did not succeed.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2011-06-23 15:41:47 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 693778    

Description Lubos Trilety 2011-04-08 14:52:33 UTC 
Description of problem:
In some cases condor_configure_store/pool give wrong return code

E.g.
1.) ccs/p should return other than zero return code
# condor_configure_store -a -f Feature; echo $?
Adding feature "Feature"
Error: Failed to add feature "Feature" (67109121, Feature name Feature is already taken)
0

# condor_configure_store -e -f Feature; echo $?
Error: Failed to find feature "Feature" (67109889, Feature named Feature not found)
0

# condor_configure_store -a -f Feature; echo $?
Adding feature "Feature"
The store does not know about the following items:
Parameter
  PP
Should the above be added to the store [Y/n]? n
The following errors were reported updating "Feature":
134218753:  Invalid parameters supplied to feature Feature:  PP
0

# condor_configure_pool -l -n node; echo $?
Error: Failed to find node "node"
0


2.) ccs/p should return zero return code
# condor_configure_store -d -f Feature; echo $?
Warning: About to delete the following entities from the store:
Features: Feature
Proceed to delete the above entities from the store [y/N]? <Enter>
1


Version-Release number of selected component (if applicable):
condor-wallaby-tools-4.0-4
wallaby-0.10.5-3
Comment 1 Robert Rati 2011-04-19 14:36:34 UTC 
The listed cases have been handle appropriately and future cases should be handled as well.

Fixed on master.
Comment 2 Robert Rati 2011-04-25 18:51:27 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
C: Providing invalid arguments, or other invalid scenarios, to the condor_configure_pool/store tools
C: The tools would indicate error, but the return value would indicate success
F: The tools properly exit with an non-zero value in error cases
R: The tools will return non-zero return codes when the actions did not succeed.
Comment 4 Lubos Trilety 2011-05-04 11:50:53 UTC 
Tested with:
condor-wallaby-tools-4.0-6

Tested on:
RHEL5 i386,x86_64  - passed
RHEL6 i386,x86_64  - passed

>>> VERIFIED
Comment 5 errata-xmlrpc 2011-06-23 15:41:47 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHEA-2011-0889.html