| Summary: | variable 'exitting' is never used | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Kamil Dudka <kdudka> |
| Component: | device-mapper-multipath | Assignee: | LVM and device-mapper development team <lvm-team> |
| Status: | CLOSED DUPLICATE | QA Contact: | Red Hat Kernel QE team <kernel-qe> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 5.7 | CC: | agk, bmarzins, bmr, dwysocha, heinzm, mbroz, mluscon, ovasik, prajnoha, prockai, zkabelac |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-04-11 16:58:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 639429 | ||
(In reply to comment #0) > Version-Release number of selected component (if applicable): > device-mapper-multipath-0.4.7-44.el5 The bug is also present in device-mapper-multipath-0.4.7-45.el5. Since that change hasn't made it through QA yet, I'm just going to dup this to the bug that originally made the change and fix it there. *** This bug has been marked as a duplicate of bug 639429 *** |
Description of problem: device-mapper-multipath-0.4.7-44.el5 adds a new variable 'exitting', which is never used. Version-Release number of selected component (if applicable): device-mapper-multipath-0.4.7-44.el5 Actual results: Error: STRAY_SEMICOLON: multipath-tools-0.4.7.rhel5.30/multipathd/main.c:1508: stray_semicolon: "if" statement "if (!exitting /* != 0 */);" with no "then" or "else" is suspicious. Additional info: --- a/multipathd/main.c +++ b/multipathd/main.c @@ -1505,7 +1505,7 @@ sighup (int sig) condlog(2, "reconfigure (SIGHUP)"); lock(gvecs->lock); - if (!exitting); + if (!exitting) reconfigure(gvecs); unlock(gvecs->lock);