Bug 695173 (CVE-2011-1576)

Summary:	CVE-2011-1576 kernel: net: Fix memory leak/corruption on VLAN GRO_DROP
Product:	[Other] Security Response	Reporter:	Eugene Teo (Security Response) <eteo>
Component:	vulnerability	Assignee:	Red Hat Product Security <security-response-team>
Status:	CLOSED ERRATA	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	unspecified	CC:	arozansk, bhu, dhoward, herbert.xu, jkacur, jwest, kernel-mgr, kmcmartin, lgoncalv, lwang, pmatouse, rkhan, rt-maint, security-response-team, sforsber, tcallawa, williams
Target Milestone:	---	Keywords:	Security
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-07-29 12:35:38 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	691565, 695174, 695175, 695176, 695177, 713524
Bug Blocks:

Description Eugene Teo (Security Response) 2011-04-11 03:07:39 UTC

net: Fix memory leak/corruption on VLAN GRO_DROP

The function napi_reuse_skb is only meant to be used for packets merged by GRO.  Using it on the VLAN path will lead to memory leaks/corruption.  This patch is based on Jay Vosburgh's patch, and it fixes the problem by calling kfree_skb on the VLAN GRO_DROP path instead of napi_reuse_skb.

The fix for CVE-2011-1478 unveiled this issue. Note, this is not a CVE-2011-1478 regression.

Acknowledgements:

Red Hat would like to thank Ryan Sweat for reporting this issue.

Comment 7 Petr Matousek 2011-06-06 16:06:41 UTC

This issue does not affect the upstream kernel as the code path in question is no longer reachable due to changes in the VLAN subsystem.

Comment 8 Petr Matousek 2011-06-06 22:07:15 UTC

Statement:

This issue did not affect the version of Linux kernel as shipped with Red Hat
Enterprise Linux 4 as it did not support Generic Receive Offload (GRO). This has been addressed in Red Hat Enterprise Linux 5, 6 and Red Hat Enterprise MRG via https://rhn.redhat.com/errata/RHSA-2011-0927.html and https://rhn.redhat.com/errata/RHSA-2011-1189.html, and https://rhn.redhat.com/errata/RHSA-2011-1253.html.

Comment 9 errata-xmlrpc 2011-07-15 06:08:37 UTC

This issue has been addressed in following products:

  Red Hat Enterprise Linux 5

Via RHSA-2011:0927 https://rhn.redhat.com/errata/RHSA-2011-0927.html

Comment 10 Eugene Teo (Security Response) 2011-07-22 03:59:47 UTC

Upstream commit:
http://git.kernel.org/linus/3701e51382a026cba10c60b03efabe534fba4ca4

Comment 11 errata-xmlrpc 2011-07-27 14:41:01 UTC

This issue has been addressed in following products:

  RHEV-H, V2V and Agents for RHEL-5

Via RHSA-2011:1090 https://rhn.redhat.com/errata/RHSA-2011-1090.html

Comment 12 errata-xmlrpc 2011-08-02 16:53:58 UTC

This issue has been addressed in following products:

  Red Hat Enterprise Linux 6.0.Z - Server Only

Via RHSA-2011:1106 https://rhn.redhat.com/errata/RHSA-2011-1106.html

Comment 13 errata-xmlrpc 2011-08-23 14:41:49 UTC

This issue has been addressed in following products:

  Red Hat Enterprise Linux 6

Via RHSA-2011:1189 https://rhn.redhat.com/errata/RHSA-2011-1189.html

Comment 14 errata-xmlrpc 2011-09-12 19:44:11 UTC

This issue has been addressed in following products:

  MRG for RHEL-6 v.2

Via RHSA-2011:1253 https://rhn.redhat.com/errata/RHSA-2011-1253.html