Bug 695401

Summary: vala-0.10.4-1.fc14 makes shotwell ftbfs
Product: [Fedora] Fedora Reporter: Rex Dieter <rdieter>
Component: valaAssignee: Michel Lind <michel>
Status: CLOSED CANTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 14CC: michel
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-01-30 23:07:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Rex Dieter 2011-04-11 15:53:43 UTC
working on a shotwell rebuild, and it failed to build against vala-0.10.4-1.fc14,

https://koji.fedoraproject.org/koji/buildinfo?buildID=238598

in particular,

mkdir -p src
valac --ccode --directory=src --basedir=src -g --enable-checking --thread  \
--pkg=atk --pkg=dbus-glib-1 --pkg=gconf-2.0 --pkg=gdk-2.0 --pkg=gdk-x11-2.0 --pkg=gee-1.0 --pkg=gexiv2 --pkg=gstreamer-0.10 --pkg=gstreamer-base-0.10 --pkg=gtk+-2.0 --pkg=glib-2.0 --pkg=gudev-1.0 --pkg=json-glib-1.0 --pkg=libexif --pkg=libgphoto2 --pkg=libsoup-2.4 --pkg=libxml-2.0 --pkg=sqlite3 --pkg=unique-1.0 --pkg=webkit-1.0 --pkg=ExtendedPosix --pkg=posix --pkg=LConv --pkg=libraw \
--vapidir=./vapi \
-X -D_PREFIX='"/usr"' -X -D_VERSION='"0.8.1"' -X -DGETTEXT_PACKAGE='"shotwell"' -X -D_LANG_SUPPORT_DIR='"/usr/share/locale"' \
-X -I./vapi \
 \
src/main.vala src/AppWindow.vala src/CollectionPage.vala src/Thumbnail.vala src/DatabaseTables.vala src/ThumbnailCache.vala src/image_util.vala src/CheckerboardLayout.vala src/PhotoPage.vala src/Page.vala src/ImportPage.vala src/GPhoto.vala src/SortedList.vala src/EventsDirectoryPage.vala src/Dimensions.vala src/Box.vala src/Photo.vala src/Orientation.vala src/util.vala src/BatchImport.vala src/Dialogs.vala src/Resources.vala src/Debug.vala src/Sidebar.vala src/ColorTransformation.vala src/EditingTools.vala src/DataObject.vala src/DataCollection.vala src/LibraryWindow.vala src/CameraTable.vala src/DirectWindow.vala src/Properties.vala src/CustomComponents.vala src/Config.vala src/Event.vala src/International.vala src/Workers.vala src/system.vala src/AppDirs.vala src/PixbufCache.vala src/WebConnectors.vala src/FacebookConnector.vala src/CommandManager.vala src/Commands.vala src/SlideshowPage.vala src/LibraryFiles.vala src/FlickrConnector.vala src/YandexConnector.vala src/Printing.vala src/Tag.vala src/TagPage.vala src/PicasaConnector.vala src/PiwigoConnector.vala src/YouTubeConnector.vala src/Screensaver.vala src/PhotoFileAdapter.vala src/PhotoFileFormat.vala src/PhotoFileSniffer.vala src/PhotoMetadata.vala src/GRaw.vala src/GdkSupport.vala src/JfifSupport.vala src/RawSupport.vala src/MimicManager.vala src/TrashPage.vala src/PngSupport.vala src/Exporter.vala src/DirectoryMonitor.vala src/LibraryMonitor.vala src/OfflinePage.vala src/LastImportPage.vala src/AlienDatabase.vala src/AlienDatabaseImportJob.vala src/AlienDatabaseImportDialog.vala src/FSpotDatabaseDriver.vala src/FSpotDatabaseTables.vala src/VideoSupport.vala src/VideosPage.vala src/Tombstone.vala src/MetadataWriter.vala src/Application.vala src/TimedQueue.vala src/MediaPage.vala src/MediaDataRepresentation.vala src/file_util.vala src/DesktopIntegration.vala src/FlaggedPage.vala src/MediaInterfaces.vala src/MediaMetadata.vala src/VideoMetadata.vala src/string_util.vala src/MediaMonitor.vala src/PhotoMonitor.vala src/VideoMonitor.vala
warning: D-Bus GLib is deprecated, use GDBus
src/CheckerboardLayout.vala:974.42-974.50: error: Argument 2: Cannot pass value to reference or output parameter
            if (area.intersect(row_rect, bitbucket)) {
                                         ^^^^^^^^^
src/CheckerboardLayout.vala:980.57-980.65: error: Argument 2: Cannot pass value to reference or output parameter
                    if (area.intersect(item.allocation, bitbucket))
                                                        ^^^^^^^^^
src/CheckerboardLayout.vala:1507.58-1507.69: error: Argument 2: Cannot pass value to reference or output parameter
            if (!visible_page.intersect(item.allocation, intersection))
                                                         ^^^^^^^^^^^^
src/CheckerboardLayout.vala:1645.48-1645.59: error: Argument 2: Cannot pass value to reference or output parameter
        visible_page.intersect(selection_band, visible_band);
                                               ^^^^^^^^^^^^
Compilation failed: 4 error(s), 1 warning(s)


All previous vala builds vala-0.9.8-1.fc14.1 through vala-0.10.3-2.fc14 seem to build it ok.

Comment 1 Michel Lind 2012-01-30 23:07:23 UTC
Didn't get around to this before the EOL -- sorry.