Bug 696498

Summary: virt-image:--prompt not take effect when create guest from xml file.
Product: Red Hat Enterprise Linux 6 Reporter: zhe peng <zpeng>
Component: python-virtinstAssignee: Cole Robinson <crobinso>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.1CC: dyuan, mzhan, nzhang
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
No description necessary
 Story Points: ---
Clone Of:
: 704480 (view as bug list) Environment:
Last Closed: 2011-12-06 16:16:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 704480    

Description zhe peng 2011-04-14 07:28:13 UTC 
Description of problem:
no prompting for required information when use virt-image --prompt to create guest from xml file

Version-Release number of selected component (if applicable):
python-virtinst-0.500.5-3.el6.noarch


How reproducible:
always

Steps to Reproduce:
1.remove all guest,run command:
# virt-image --prompt virt-image.xml
there is no prompting for required.

strangely, if a same name domain exist,
[root@localhost tmp]# virsh list --all
 Id Name                 State
----------------------------------
  1 rhel6_x86_64_qcow2   running
  2 test                 running
  3 new                  running
 then run command:
[root@localhost tmp]# virt-image --prompt virt-image.xml 
ERROR    Guest name 'test' is already in use.
What is the name of your virtual machine? 
new


Creating guest new...
Creating domain...    
the prompting will shown up.
i check man help and --help of virt-image, all missing --prompt option detail,but --force exist.
  
Actual results:


Expected results:


Additional info:
Comment 1 Cole Robinson 2011-06-10 19:53:01 UTC 
Rather than adding --prompting, we should just hide the option until there is something reasonable to prompt for.
Comment 2 Cole Robinson 2011-07-14 01:48:06 UTC 
Upstream now hides both --prompt and --force options, and doesn't have the weird prompting behavior you mention above. Truthfully the --prompt behavior is a pain to maintain so it will probably never be fully implemented for virt-image.
Comment 3 Cole Robinson 2011-07-28 15:34:23 UTC 
Fixed in python-virtinst-0.600.0-1.el6
Comment 5 zhe peng 2011-08-01 02:58:31 UTC 
verify with:
python-virtinst-0.600.0-1.el6.noarch
libvirt-0.9.4-0rc1.el6.x86_64
qemu-kvm-0.12.1.2-2.172.el6.x86_64

step:

#virsh list --all
 Id Name                 State
----------------------------------
  7 demo                 running
 20 test                 running
#cat image.xml
 <image>
    <name>test</name>
      <domain>
        <boot type="hvm">
         <guest>
           <arch>x86_64</arch>
         </guest>
        <os>
...
#virt-image --prompt image.xml
ERROR    Guest name 'test' is already in use.
no prompt shown up.
verification passed.
Comment 6 Cole Robinson 2011-11-07 16:52:53 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No description necessary
Comment 7 errata-xmlrpc 2011-12-06 16:16:42 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1643.html