| Summary: | LastSuspensionTime should be NA instead of 31 Dec 1969 19:00 | ||
|---|---|---|---|
| Product: | Red Hat Enterprise MRG | Reporter: | Jan Sarenik <jsarenik> |
| Component: | cumin | Assignee: | Chad Roberts <croberts> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Jan Sarenik <jsarenik> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | Development | CC: | iboverma, matt, tmckay |
| Target Milestone: | 2.0 | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | cumin-0.1.4725-1 | Doc Type: | Bug Fix |
| Doc Text: |
Cause: Some fields were editable that should not have been (things like remote system time, etc). In addition, a user was allowed to edit fields for completed jobs, which doesn't make any sense. The result of editing the fields was that errors would show up in the yellow notification area.
Consequence: As a result of the attempted edits, several errors would be thrown into the yellow notification area.
Fix: We have made several fields unwritable for jobs that are running or still to be run. In addition, for completed jobs, the "edit attributes" button will no longer appear.
Result: The user should not be able to edit fields that do not make any sense, nor should they be able to attempt to edit the attributes of any completed job.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-06-27 14:29:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Jan Sarenik
2011-04-14 12:53:59 UTC
cumin-0.1.4712-1.el5 ehm, on my local instance the time is LastSuspensionTime 01 Jan 1970 01:00 (probably TimeZone shift). After submitting a job...
$ condor_q -l | grep ^LastSuspensionTime
LastSuspensionTime = 0
qpid: call 3251 GetJobAd "7403.0"
OK (0) - {u'JobAd': {..., u'LastSuspensionTime': 0, ...}}
LastSuspensionTime is 0 in the data.
src/condor_schedd.V6/schedd.cpp -
mark_job_running(PROC_ID* job_id)
...
status = RUNNING;
...
SetAttributeInt(job_id->cluster, job_id->proc,
ATTR_LAST_SUSPENSION_TIME, 0 );
...
Throughout the code 0 is used as a special Unset/Null/Nil value. The code should arguably be fixed to properly used UNDEFINED.
Best current approach is to handle 0 specially in Cumin.
In order to fix this we now take an extra step when converting the timestamp into a date for display. If the timestamp given is non-positive, we give a value of "NA" rather than a timezone adjusted version of the epoch. This is available in revision 4715. Verified in cumin-0.1.4725-1.el5
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
New Contents:
Cause: Some fields were editable that should not have been (things like remote system time, etc). In addition, a user was allowed to edit fields for completed jobs, which doesn't make any sense. The result of editing the fields was that errors would show up in the yellow notification area.
Consequence: As a result of the attempted edits, several errors would be thrown into the yellow notification area.
Fix: We have made several fields unwritable for jobs that are running or still to be run. In addition, for completed jobs, the "edit attributes" button will no longer appear.
Result: The user should not be able to edit fields that do not make any sense, nor should they be able to attempt to edit the attributes of any completed job.
|