Bug 696749
Summary: | PATCH: Run undefined-non-weak-symbols through c++filt to improve readability. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Richard Shaw <hobbes1069> | ||||||
Component: | rpmlint | Assignee: | Tom "spot" Callaway <tcallawa> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | low | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | 14 | CC: | a.badger, manuel.wolfshant, tcallawa, tmz, ville.skytta | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | rpmlint-1.2-1.fc14 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2011-05-01 03:27:13 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Created attachment 492207 [details]
Revised patch
Figured it out. Changed from subprocess.Popen to subprocess.check_output.
We have Pkg.getstatusoutput for that purpose in rpmlint. Modified patch applied upstream, thanks: http://rpmlint.zarb.org/cgi-bin/trac.cgi/changeset/1850 rpmlint-1.2-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rpmlint-1.2-1.fc14 rpmlint-1.2-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/rpmlint-1.2-1.fc15 rpmlint-1.2-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rpmlint-1.2-1.fc13 Package rpmlint-1.2-1.fc14: * should fix your issue, * was pushed to the Fedora 14 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing rpmlint-1.2-1.fc14' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/rpmlint-1.2-1.fc14 then log in and leave karma (feedback). rpmlint-1.2-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. rpmlint-1.2-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. rpmlint-1.2-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 492201 [details] Patch to run symbols through c++filt Description of problem: rpmlint currently outputs the raw symbols Version-Release number of selected component (if applicable): 1.0-2 Additional info: I have a quick patch to filter the symbols through c++filt but I'm not up on my python and for some reason it's outputting the Popen object reference with the un-mangled symbol name. Should be trivial to fix that.