Bug 697255

Summary: installer allows upgrade of release older than previous two releases
Product: [Fedora] Fedora Reporter: Steve Tyler <stephent98>
Component: pungiAssignee: Dennis Gilmore <dennis>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 15CC: dcantrell, jonathan, vanmeeuwen+fedora
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-07 16:07:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
screenshot showing installer offering to upgrade F12 none

Description Steve Tyler 2011-04-17 09:12:53 UTC
Created attachment 492684 [details]
screenshot showing installer offering to upgrade F12

Description of problem:
I installed F12 in a VM and then upgraded to F15. According to the "Cannot Upgrade" dialog, that should not be allowed.

Version-Release number of selected component (if applicable):
F15-Beta-Final

How reproducible:
Always.

Steps to Reproduce:
1. Install a minimal F12 with default, full-disk partitioning.
   ("minimal" means Base and Admin tools)
2. Boot into the F12 system and
   verify that /etc/fedora-release exists and is valid.
   # rpm -V fedora-release
2. Upgrade to F15.
  
Actual results:
Upgrade is allowed and completes.
F15 boots to a login prompt, although NetworkManager aborts.
There are temporary stalls booting and shutting down.

Expected results:
Get the "Cannot Upgrade" dialog.

Additional info:
I did not update the F12 system after completing the install.

Tested in a VM:
$ qemu-kvm -m 1024 -cdrom ../../F12/Fedora-12-i386-DVD.iso -hda ../f15-test1.img -boot menu=on
$ qemu-kvm -m 1024 -cdrom Fedora-15-Beta-i386-DVD.iso -hda ../f15-test1.img -boot menu=on

Bug 697047 - "Cannot Upgrade" message reinstalling onto VM disk image after
cancelled install
Bug 697193 - installer fails to report missing or corrupt /etc/fedora-release
Bug 697236 - installer fails to detect corrupt /etc/fedora-release

Comment 1 Chris Lumens 2011-04-17 15:48:12 UTC
This is because the .buildstamp file contains:

Version=15-Beta

Which doesn't turn into a number - it turns into a traceback.  If we wrote real version numbers into .buildstamp, this would all work just fine.  I think this comes up about every release.  Anyway it won't be a problem in the final.

Comment 2 Steve Tyler 2011-04-17 15:55:23 UTC
(In reply to comment #1)
> This is because the .buildstamp file contains:
> 
> Version=15-Beta
> 
> Which doesn't turn into a number - it turns into a traceback.  If we wrote real
> version numbers into .buildstamp, this would all work just fine.  I think this
> comes up about every release.  Anyway it won't be a problem in the final.

Thanks for the explanation.

> If we wrote real
> version numbers into .buildstamp ...

OK, I'll bite ... is there a bug I can open? ;-)
Or should I just retitle this one?

Comment 3 Steve Tyler 2011-04-17 16:32:09 UTC
(In reply to comment #1)
> This is because the .buildstamp file contains:
> 
> Version=15-Beta
> 
> Which doesn't turn into a number - it turns into a traceback.  If we wrote real
> version numbers into .buildstamp, this would all work just fine.  I think this
> comes up about every release.  Anyway it won't be a problem in the final.

IIUC, it is impossible to test whether releases older than two previous cannot be upgraded with Alpha or Beta releases.

This means testers waste their time ... :-(

Comment 4 Steve Tyler 2011-04-17 16:47:35 UTC
(In reply to comment #1)
> This is because the .buildstamp file contains:
> 
> Version=15-Beta
> 
> Which doesn't turn into a number - it turns into a traceback.  If we wrote real
> version numbers into .buildstamp, this would all work just fine.  I think this
> comes up about every release.  Anyway it won't be a problem in the final.

Couldn't the installer parse "15-Beta" and turn it into a "real version number"?

Comment 5 Jesse Keating 2011-04-18 19:22:48 UTC
Passing the buck on to somebody else :)

Comment 6 Dennis Gilmore 2011-04-18 19:56:51 UTC
assigning to the correct person

Comment 7 Steve Tyler 2011-04-23 12:29:06 UTC
This anaconda commit appears to address this bug:

When checking for allowing an upgrade, trim off any "-Alpha" or "-Beta".
This means that 15-Beta cannot be used to upgrade F12, but it could be used
to upgrade F14.
http://git.fedorahosted.org/git/?p=anaconda.git;a=commitdiff;h=779f77dec994205e5799ff536ad9328e4bd365b2

Comment 8 Fedora Admin XMLRPC Client 2012-02-10 18:58:48 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 9 Fedora End Of Life 2012-08-07 16:07:06 UTC
This message is a notice that Fedora 15 is now at end of life. Fedora
has stopped maintaining and issuing updates for Fedora 15. It is
Fedora's policy to close all bug reports from releases that are no
longer maintained. At this time, all open bugs with a Fedora 'version'
of '15' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that
we were unable to fix it before Fedora 15 reached end of life. If you
would still like to see this bug fixed and are able to reproduce it
against a later version of Fedora, you are encouraged to click on
"Clone This Bug" (top right of this page) and open it against that
version of Fedora.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

The process we are following is described here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping