Bug 697540

Description of problem:
I noticed that when submitting a empty provider creation form, a green error message appears stating 'Failed to connect to Provider'.  Pretty sure that failures like this one should be red.

Version-Release number of selected component (if applicable):
aeolus-conductor-doc-0.0.3-6.el6.x86_64
aeolus-conductor-0.0.3-6.el6.x86_64
aeolus-conductor-daemons-0.0.3-6.el6.x86_64
aeolus-configure-2.0.0-8.el6.noarch


How reproducible:


Steps to Reproduce:
1.  Click Administration -> Providers
2.  Click on the Create Button
3.  Click on the save button (without entering any info)
  
Actual results:
Failed to connect to Provider in green box

Expected results:
error messages are usually red

Additional info:

Here is a list of messages that I think need fixing
=============================================================
admin/provider_accounts_controller.rb:      flash[:notice] = "You must select some accounts first."   
admin/settings_controller.rb:            flash[:notice] = "Could not update the default quota"   
admin/providers_controller.rb:      flash[:notice] = "Failed to connect to Provider"   
admin/providers_controller.rb:        flash[:notice] = "Cannot add the provider."
admin/providers_controller.rb:      flash[:notice] = "Failed to connect to Provider"
admin/providers_controller.rb:        flash[:notice] = "Cannot update the provider."
admin/providers_controller.rb:      flash[:notice] = "Failed to Connect to Provider"
quotas_controller.rb:      flash[:notice] = "Could not update quota, please check you have entered valid values"


Here is the full list of flash messages from controllers
=============================================================
[root@ip-10-118-26-86 app]# cd controllers
[root@ip-10-118-26-86 controllers]# grep -r flash *
admin/provider_accounts_controller.rb:      flash[:error] = "You don't have any provider yet. Please create one!"
admin/provider_accounts_controller.rb:      flash[:error] = "Credentials are invalid!"
admin/provider_accounts_controller.rb:      flash[:notice] = "Provider account added."
admin/provider_accounts_controller.rb:      flash[:notice] = "Provider Account updated!"
admin/provider_accounts_controller.rb:      flash[:error] = "Provider Account wasn't updated!"
admin/provider_accounts_controller.rb:      flash[:notice] = "You must select some accounts first."
admin/provider_accounts_controller.rb:      flash[:notice] = t 'provider_accounts.index.account_deleted', :count => succeeded.length, :list => succeeded.join(', ')
admin/provider_accounts_controller.rb:      flash[:error] = t 'provider_accounts.index.account_not_deleted', :count => failed.length, :list => failed.join(', ')
admin/provider_accounts_controller.rb:      flash.now[:notice] = "Test Connection Success: Valid Account Details"
admin/provider_accounts_controller.rb:      flash.now[:error] = "Test Connection Failed: Invalid Account Details"
admin/provider_accounts_controller.rb:    flash.now[:error] = "Test Connection Failed: Could not connect to provider"
admin/users_controller.rb:      flash.now[:warning] = "User registration failed: #{@registration.error}"
admin/users_controller.rb:      flash[:notice] = "User registered!"
admin/users_controller.rb:      flash[:notice] = "You have successfully registered!"
admin/users_controller.rb:      flash[:notice] = "User updated!"
admin/users_controller.rb:        flash[:warning] = "Cannot delete #{user.login}: you are logged in as this user"
admin/users_controller.rb:      flash[:notice] =  "#{msg}: #{deleted_users.join(', ')}"
admin/settings_controller.rb:            flash[:notice] = "Could not update the default quota"
admin/settings_controller.rb:    flash[:notice] = "Settings Updated!"
admin/providers_controller.rb:      flash[:notice] = "Failed to connect to Provider"
admin/providers_controller.rb:        flash[:notice] = "Provider added."
admin/providers_controller.rb:        flash[:notice] = "Cannot add the provider."
admin/providers_controller.rb:      flash[:notice] = "Failed to connect to Provider"
admin/providers_controller.rb:        flash[:notice] = "Provider updated."
admin/providers_controller.rb:        flash[:notice] = "Cannot update the provider."
admin/providers_controller.rb:      flash[:notice] = "Successfuly Connected to Provider"
admin/providers_controller.rb:      flash[:notice] = "Failed to Connect to Provider"
admin/realms_controller.rb:      flash[:notice] = 'Realm updated successfully!'
admin/realms_controller.rb:      flash[:notice] = "Realm was added."
admin/realms_controller.rb:      flash[:error] = 'You must select at least one realm to delete.'
admin/roles_controller.rb:      flash[:notice] = 'Role successfully saved!'
admin/roles_controller.rb:      flash[:notice] = 'Role updated successfully!'
admin/hardware_profiles_controller.rb:      flash[:notice] = "Hardware Profile updated!"
admin/pool_families_controller.rb:      flash.now[:warning] = "Pool family's creation failed."
admin/pool_families_controller.rb:      flash[:notice] = "Pool family was added."
admin/pool_families_controller.rb:      flash[:error] = "Pool Family wasn't updated!"
admin/pool_families_controller.rb:      flash[:notice] = "Pool Family was updated!"
admin/pool_families_controller.rb:      flash[:notice] = t 'pool_families.index.deleted', :list => deleted.join(', ')
admin/pool_families_controller.rb:      flash[:error] = t 'pool_families.index.not_deleted', :list => not_deleted.join(', ')
admin/realm_mappings_controller.rb:      flash[:notice] = "Realm mapping was added."
admin/realm_mappings_controller.rb:      flash[:error] = 'You must select at least one mapping to delete.'
application_controller.rb:    flash[:errmsg] = error.message
application_controller.rb:    flash[:notice] = "The record you tried to access does not exist, it may have been deleted"
application_controller.rb:    # inline in the form, and once in the flash
application_controller.rb:    flash[:notice] = "You must be logged in to access this page"
application_controller.rb:    flash[:notice] = "You must be logged out to access this page"
image_factory/image_imports_controller.rb:      flash[:notice]="Image successfully imported"
image_factory/image_imports_controller.rb:      flash.now[:error]=e.message
image_factory/deployables_controller.rb:      flash[:notice] = "Deployable added."
image_factory/deployables_controller.rb:      flash[:notice] = "Deployable updated."
image_factory/templates_controller.rb:      flash[:notice] = "Template saved."
image_factory/templates_controller.rb:      flash[:notice] = "Template updated."
image_factory/templates_controller.rb:        flash[:error] = "You don't have a permission to delete."
image_factory/templates_controller.rb:  def flash_error(summary, errs)
image_factory/templates_controller.rb:    flash.now[:error] ||= {}
image_factory/templates_controller.rb:    flash.now[:error][:summary] = summary
image_factory/templates_controller.rb:    flash.now[:error][:failures] ||= {}
image_factory/templates_controller.rb:    flash.now[:error][:failures].merge!(errs)
image_factory/templates_controller.rb:      flash[:warning] = ids.empty? ? 'No Template Selected' : 'You can select only one template'
image_factory/builds_controller.rb:      flash[:error] = "Warning: #{$!.message}"
image_factory/builds_controller.rb:          flash[:notice] = "Queued rebuild for image #{image.name}"
image_factory/builds_controller.rb:          flash[:warning] = "could not find image #{image_id}"
image_factory/builds_controller.rb:          flash[:notice] = "Queued upload of provider image #{provider_image.image.name} to #{provider_image.provider.name}"
image_factory/builds_controller.rb:          flash[:warning] = "could not find provider image #{provider_image_id}"
image_factory/builds_controller.rb:        flash[:warning] = 'You need to specify either a provider or a provider image'
image_factory/builds_controller.rb:      flash[:warning] = $!.message
permissions_controller.rb:      flash[:notice] = "Permission record added."
quotas_controller.rb:      flash[:notice] = "Quota updated!"
quotas_controller.rb:      flash[:notice] = "Could not update quota, please check you have entered valid values"
quotas_controller.rb:      flash[:notice] = "Quota updated!"
resources/pools_controller.rb:      flash[:notice] = "Pool added."
resources/pools_controller.rb:      flash[:notice] = "Pool updated."
resources/pools_controller.rb:        flash[:notice] = "The default pool cannot be deleted"
resources/instances_controller.rb:      flash[:warning] = "Failed to launch instance: #{$!}"
resources/instances_controller.rb:        flash[:notice] = "Instance added."
resources/instances_controller.rb:        flash[:warning] = "Quota Exceeded: Instance will not start until you have free quota"
resources/instances_controller.rb:    flash[:warning] = "SSH Key not found for this Instance."
resources/instances_controller.rb:    flash[:notice] = notices unless notices.blank?
resources/instances_controller.rb:    flash[:error] = errors unless errors.blank?
resources/instances_controller.rb:    flash[:notice] = notices unless notices.blank?
resources/instances_controller.rb:    flash[:error] = errors unless errors.blank?
user_sessions_controller.rb:      flash[:notice] = "Login successful!"
user_sessions_controller.rb:      flash[:warning] = "Login failed: The Username and Password you entered do not match"
user_sessions_controller.rb:    flash[:notice] = "Logout successful!"