Bug 697767
| Summary: | Review Request: rubygem-spruz - Useful tools library in Ruby | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | James Ni <jni> | ||||
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review, notting, petersen, pwu, vondruch | ||||
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
j: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | rubygem-spruz-0.2.5-3.fc14 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-04-26 16:22:42 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
James Ni
2011-04-19 08:01:11 UTC
Koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=3010159 Created attachment 493704 [details]
modified spec to follow ruby guidelines
Modifications done are
- Subpackage doc files.
- Drop %%{buildroot}, %%clean section and cleaning
of buildroot in %%install.
- Fix the permission issue for enum and install.rb file.
- Fix the shebang in script files.
Thanks, I have update the package and spec file Spec URL: http://jamesni.fedorapeople.org/rubygem-spruz/rubygem-spruz.spec SRPM URL: http://jamesni.fedorapeople.org/rubygem-spruz/rubygem-spruz-0.2.5-2.fc13.src.rpm Review: + Koji build-> http://koji.fedoraproject.org/koji/taskinfo?taskID=3015357 + upstream source verified as (sha1sum) 55f827c5bff7716c0230465fca9b2d765ca9d612 ../SOURCES/spruz-0.2.5.gem 55f827c5bff7716c0230465fca9b2d765ca9d612 spruz-0.2.5.gem + rpmlint gave rubygem-spruz.noarch: W: no-manual-page-for-binary enum rubygem-spruz-doc.noarch: W: no-documentation rubygem-spruz-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/spruz-0.2.5/ri/Array/uniq_by%21-i.yaml %21 rubygem-spruz-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/spruz-0.2.5/ri/Spruz/Full/full%3f-i.yaml %3f rubygem-spruz-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/spruz-0.2.5/ri/Spruz/Bijection/%5b%5d-c.yaml %5b rubygem-spruz-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/spruz-0.2.5/ri/Spruz/Bijection/%5b%5d-c.yaml %5d rubygem-spruz-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/spruz-0.2.5/ri/Spruz/Minimize/unminimize%21-i.yaml %21 rubygem-spruz-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/spruz-0.2.5/ri/Spruz/Bijection/%5b%5d%3d-i.yaml %5b rubygem-spruz-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/spruz-0.2.5/ri/Spruz/Bijection/%5b%5d%3d-i.yaml %5d rubygem-spruz-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/spruz-0.2.5/ri/Spruz/Bijection/%5b%5d%3d-i.yaml %3d rubygem-spruz-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/spruz-0.2.5/ri/Spruz/Minimize/minimize%21-i.yaml %21 rubygem-spruz-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/spruz-0.2.5/ri/Spruz/ModuleGroup/%5b%5d-c.yaml %5b rubygem-spruz-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/spruz-0.2.5/ri/Spruz/ModuleGroup/%5b%5d-c.yaml %5d rubygem-spruz-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/spruz-0.2.5/ri/Hash/subhash%21-i.yaml %21 rubygem-spruz-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/spruz-0.2.5/ri/Spruz/Shuffle/shuffle%21-i.yaml %21 rubygem-spruz-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/spruz-0.2.5/ri/Spruz/HashUnion/%7c-i.yaml %7c rubygem-spruz-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/spruz-0.2.5/ri/Spruz/Generator/%5b%5d-c.yaml %5b rubygem-spruz-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/spruz-0.2.5/ri/Spruz/Generator/%5b%5d-c.yaml %5d 4 packages and 0 specfiles checked; 0 errors, 20 warnings. I am not able to get testsuite working. vondruch, Is it possible to get testsuite working here? I think rest looks ok. Only need to check if we can have testsuite working here. I will not block this review for that. APPROVED. New Package SCM Request ======================= Package Name: rubygem-spruz Short Description: All the stuff that isn't good/big enough for a real library. Owners: jamesni Branches: f13 f14 f15 el6 InitialCC: pwu petersen i18n-team > I am not able to get testsuite working.
>
> vondruch,
> Is it possible to get testsuite working here?
Add BuildRequires: rubygem(test-unit)
And then execute
RUBYOPT="I%{buildroot}%{geminstdir}/lib" testrb2 tests/test_*.rb
The test-unit which is integral part of Ruby is not that powerful.
Thanks, just update the package and spec file Spec URL: http://jamesni.fedorapeople.org/rubygem-spruz/rubygem-spruz.spec SRPM URL: http://jamesni.fedorapeople.org/rubygem-spruz/rubygem-spruz-0.2.5-3.fc13.src.rpm Git done (by process-git-requests). rubygem-spruz-0.2.5-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-spruz-0.2.5-3.fc14 rubygem-spruz-0.2.5-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/rubygem-spruz-0.2.5-3.fc15 rubygem-spruz-0.2.5-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-spruz-0.2.5-3.fc13 Package rubygem-spruz-0.2.5-3.fc14: * should fix your issue, * was pushed to the Fedora 14 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing rubygem-spruz-0.2.5-3.fc14' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/rubygem-spruz-0.2.5-3.fc14 then log in and leave karma (feedback). rubygem-spruz-0.2.5-3.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. rubygem-spruz-0.2.5-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. rubygem-spruz-0.2.5-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |