Bug 697778
| Summary: | Review Request: rubygem-formtastic - A Rails form builder plugin with semantically rich and accessible markup | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daiki Ueno <dueno> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora-package-review, notting, petersen, vondruch |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-formtastic-1.2.3-4.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-05-19 04:45:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Daiki Ueno
2011-04-19 08:41:58 UTC
Reflected off-line comments from Parag: - License is "MIT", not "GPLv2+ or Ruby" - Version requirements like ">= 0" are not necessary Spec URL: http://ueno.fedorapeople.org/rubygem-formtastic/rubygem-formtastic.spec SRPM URL: http://ueno.fedorapeople.org/rubygem-formtastic/rubygem-formtastic-1.2.3-2.fc15.src.rpm Review: 1) koji build->http://koji.fedoraproject.org/koji/taskinfo?taskID=3012790 2) rpmlint output is rubygem-formtastic.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/formtastic-1.2.3/ri/Formtastic/SemanticFormBuilder/options_require_validation%3f-i.yaml %3f rubygem-formtastic.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/formtastic-1.2.3/ri/Formtastic/SemanticFormBuilder/detect_label_and_value_method%21-i.yaml %21 rubygem-formtastic.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/formtastic-1.2.3/ri/Formtastic/Util/rails3%3f-i.yaml %3f rubygem-formtastic.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/formtastic-1.2.3/ri/Formtastic/SemanticFormBuilder/has_errors%3f-i.yaml %3f rubygem-formtastic.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/formtastic-1.2.3/ri/Formtastic/SemanticFormBuilder/is_file%3f-i.yaml %3f rubygem-formtastic.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/formtastic-1.2.3/ri/Formtastic/SemanticFormBuilder/render_inline_errors%3f-i.yaml %3f ==> But as upstream has introduced naming for above files we can ignore this. 3) upstream source verified as b1e67ba4cd4574a307a868af585a9243a3a8df54 formtastic-1.2.3.gem b1e67ba4cd4574a307a868af585a9243a3a8df54 ../SOURCES/formtastic-1.2.3.gem suggestions 1) I think you can drop the gem word from summary so it will be "A Rails form builder plugin with semantically rich and accessible markup" Description can be added as "Formtastic is a Rails FormBuilder DSL (with some other goodies) to make it far easier to create beautiful, semantically rich, syntactically awesome, readily stylable and wonderfully accessible HTML forms in your Rails applications." 2)Generally we don't want to add versions to Requires also so that yum should always pull latest dependencies. Please drop the versions. 3) fix the duplicate lines Requires: rubygem(i18n) => 0.4 Requires: rubygem(i18n) < 1 4) I think you can also add -doc subpackage Thanks, updated. Spec URL: http://ueno.fedorapeople.org/rubygem-formtastic/rubygem-formtastic.spec SRPM URL: http://ueno.fedorapeople.org/rubygem-formtastic/rubygem-formtastic-1.2.3-3.fc15.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3012860 Fixed some mistakes. Spec URL: http://ueno.fedorapeople.org/rubygem-formtastic/rubygem-formtastic.spec SRPM URL: http://ueno.fedorapeople.org/rubygem-formtastic/rubygem-formtastic-1.2.3-4.fc15.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3013018 Thanks for your updates. APPROVED. Thanks for the review, Parag. New Package SCM Request ======================= Package Name: rubygem-formtastic Short Description: A Rails form builder plugin with semantically rich and accessible markup Owners: ueno Branches: f15 f14 f13 InitialCC: It would be nice if you could execute test suite during build. (In reply to comment #7) > It would be nice if you could execute test suite during build. Thanks for the suggestion. Well, it seems not that easy since formtastic-1.2.3.gem does not contain test suite (it is available in the git tree though). We will need: - include the test suite taken from the git - package rspec related gems in development dependencies (rspec_tag_matchers and rspec-rails) I would like to postpone the task for now. Git done (by process-git-requests). rubygem-formtastic-1.2.3-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-formtastic-1.2.3-4.fc14 rubygem-formtastic-1.2.3-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/rubygem-formtastic-1.2.3-4.fc15 rubygem-formtastic-1.2.3-4.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-formtastic-1.2.3-4.fc13 Please add a branch for EPEL. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3015514 Package Change Request ====================== Package Name: rubygem-formtastic New Branches: el6 Owners: ueno (In reply to comment #8) > (In reply to comment #7) > > It would be nice if you could execute test suite during build. > > Thanks for the suggestion. Well, it seems not that easy since > formtastic-1.2.3.gem does not contain test suite (it is available in the git > tree though). We will need: > > - include the test suite taken from the git > - package rspec related gems in development dependencies (rspec_tag_matchers > and rspec-rails) > > I would like to postpone the task for now. Yes, that is the way. It is not blocker, but I hope you will find some day time to add it. rubygem-formtastic-1.2.3-4.fc14 has been pushed to the Fedora 14 testing repository. Git done (by process-git-requests). rubygem-formtastic-1.2.3-4.fc15 has been pushed to the Fedora 15 stable repository. rubygem-formtastic-1.2.3-4.fc14 has been pushed to the Fedora 14 stable repository. rubygem-formtastic-1.2.3-4.fc13 has been pushed to the Fedora 13 stable repository. |