Bug 697801

Suggestions:
1) Each Ruby package MUST indicate the Ruby ABI version it depends on. Add
following at top lines
   %global rubyabi 1.8
2) missing BR
BuildRequires: ruby(abi) = %{rubyabi}
3) For fedora we don't need buildroot,%clean section and cleaning of buildroot
in %install
4) I think following can be skipped from -doc subpackage as its already installed by main package
%doc %{geminstdir}/[A-Z]*

oops I just realized that its actually missing Requires and not BR: in above 2)

and as per ruby packaging guidelines, each package should BR: ruby

Could you please execute test suite during build?

Updated. no bumped version.

(In reply to comment #1)
> 4) I think following can be skipped from -doc subpackage as its already
> installed by main package
> %doc %{geminstdir}/[A-Z]*

just concerned that rpmlint complains no doc for -doc. guess it's not a big deal.

(In reply to comment #3)
> Could you please execute test suite during build?

I'm not sure if unit test code in every gem packages is well maintained though, is it really worth doing with even adding rake and other deps to BR, which isn't necessary for real build?

(In reply to comment #5)
> (In reply to comment #3)
> > Could you please execute test suite during build?
> 
> I'm not sure if unit test code in every gem packages is well maintained though,
> is it really worth doing with even adding rake and other deps to BR, which
> isn't necessary for real build?

You don't have to use rake to execute test suite: http://fedoraproject.org/wiki/Packaging_talk:Ruby

And yes, it is worth of. For example Sinatra was recently broken after update, because new dependency was introduced. You cannot catch such change without testsuite or careful testing.

(In reply to comment #4)
> Updated. no bumped version.
> 
> (In reply to comment #1)
> > 4) I think following can be skipped from -doc subpackage as its already
> > installed by main package
> > %doc %{geminstdir}/[A-Z]*
> 
> just concerned that rpmlint complains no doc for -doc. guess it's not a big
> deal.

There is LICENSE file which should be IMO in both packages. Otherwise there are small discrepancy in opinions if files in -doc subpackage should or should not be marked as doc.

I think if license text files are added in main package then -doc don't need to include them again considering we have guideline -> http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing


I see unit test is failing. Otherwise package looks ok.

+ Koji Build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3015355
+ upstream source verified as
51331aa7cf9fff5e75bf302aeb4ebb057087ed2b  ../SOURCES/recaptcha-0.3.1.gem
51331aa7cf9fff5e75bf302aeb4ebb057087ed2b  recaptcha-0.3.1.gem
+ rpmlint output is silent.

APPROVED.

(In reply to comment #8)
> I think if license text files are added in main package then -doc don't need to
> include them again considering we have guideline ->
> http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing

You are right, the -doc subpackage requires the base package, then the license doesn't need to be included in both.

Sure. will fix that though, even "rake test" fails. I'll disable it so far and revisit when upstream fixes it..

New Package SCM Request
=======================
Package Name: rubygem-recaptcha
Short Description: Helpers for reCAPTCHA API
Owners: tagoh
Branches: f14 f15 el6
InitialCC:

Git done (by process-git-requests).

Thanks. package has been built.

Package Change Request
======================
Package Name: rubygem-recaptcha
Unretire Branches: f19
Owners: vondruch

I accidentally clicked on retire button in pkgdb :/ Than you for your help.

Resolved, I am clearing the flag.