Bug 697867

Summary: smartd prints "internal error in MailWarning(): cfg.mailwarn->emailfreq=0" when no mailaddress is specified
Product: Red Hat Enterprise Linux 6 Reporter: Christian Horn <chorn>
Component: smartmontoolsAssignee: Michal Hlavinka <mhlavink>
Status: CLOSED ERRATA QA Contact: qe-baseos-tools-bugs
Severity: high Docs Contact:
Priority: urgent    
Version: 6.0CC: azelinka, jwest, pkovar, plyons, rvokal, syeghiay
Target Milestone: rc   
Target Release: 6.2   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Prior to this update, when a system event relevant to smartd happened, the following spurious error message was output if no mail address was configured: "smartd: internal error in MailWarning(): cfg.mailwarn->emailfreq=0" This unintended behavior has been fixed in this update so that the spurious error message is no longer displayed.
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-08-24 10:56:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 658636    
Attachments:
Description Flags
the patch at currently used
none
the patch as suggested/fixed version none

Description Christian Horn 2011-04-19 13:53:32 UTC
Description of problem:
smartd not only outputs the relevant event notification but also message:
"smartd: internal error in MailWarning(): cfg.mailwarn->emailfreq=0"

Version-Release number of selected component (if applicable):
5.39.1-2.el6

How reproducible:
always

Steps to Reproduce:
1. # config example applies to ata/sata harddisc
   # the relevant part is that no -m mail is specified
   echo '/dev/sda -a -d sat' >/etc/smartd.conf
2. echo 'smartd_opts="-q never"' >/etc/sysconfig/smartmontools
3. service smartd restart
4. have a smartd relevant event happening, i.e. disc failure
  
Actual results:
output of event notification in syslog
smartd: internal error in MailWarning(): cfg.mailwarn->emailfreq=0

Expected results:
output of event notification in syslog

Additional info:
- the problem is not in unpatched smartmontools-5.39.1
- patch smartmontools-5.38-lowcap.patch removes a check which checks in
function MailWarning if mails are configured.
Removing lines 99-108 should solve the problem.

Comment 1 Michal Hlavinka 2011-04-19 14:55:22 UTC
> Removing lines 99-108 should solve the problem.

yes, this section of the patch should be removed

Comment 2 Christian Horn 2011-05-06 10:15:27 UTC
Created attachment 497319 [details]
the patch at currently used

Comment 3 Christian Horn 2011-05-06 10:16:14 UTC
Created attachment 497320 [details]
the patch as suggested/fixed version

Comment 4 Christian Horn 2011-05-06 10:17:03 UTC
Can we get the required ACKs once RHEL6.1 is GA?

Comment 14 Petr Kovar 2011-08-04 14:09:20 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Prior to this update, when a system event relevant to smartd happened, the following spurious error message was output if no mail address was configured: 

"smartd: internal error in MailWarning(): cfg.mailwarn->emailfreq=0" 

This unintended behavior has been fixed in this update so that the spurious error message is no longer displayed.

Comment 15 errata-xmlrpc 2011-08-24 10:56:46 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-1201.html