Bug 698365

Summary: RFE: add rha:description="fence_name" attribute to fence attribute group elements
Product: Red Hat Enterprise Linux 6 Reporter: Ryan McCabe <rmccabe>
Component: fence-agentsAssignee: Lon Hohberger <lhh>
Status: CLOSED ERRATA QA Contact: Cluster QE <mspqa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.1CC: ccaulfie, cluster-maint, djansa, fdinitto, lhh, mjuricek, rpeterso, ssaha, teigland
Target Milestone: rcKeywords: FutureFeature
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: fence-agents-3.1.5-4.el6 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 12:22:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 504290, 693781    
Attachments:
Description Flags
Fix
none
Fix, pass 2 none

Description Ryan McCabe 2011-04-20 17:54:34 UTC 
Currently the schema has e.g.,

<!-- fence_apc -->
<group>
...

The request is to change the group element to e.g.,

<!-- fence_apc -->
<group rha:description="fence_apc">
...
Comment 6 Lon Hohberger 2011-07-22 13:50:11 UTC 
Created attachment 514702 [details]
Fix
Comment 7 Lon Hohberger 2011-07-22 13:50:49 UTC 
(Oops, that's only one part)
Comment 8 Fabio Massimo Di Nitto 2011-07-22 14:21:51 UTC 
(In reply to comment #6)
> Created attachment 514702 [details]
> Fix

ACK for the auto-generated bits. The .head will need manual love for the static agents (as comment #7 mention ;))
Comment 9 Lon Hohberger 2011-07-22 16:02:57 UTC 
Yep, noticed that later.
Comment 10 Lon Hohberger 2011-07-22 16:03:23 UTC 
Created attachment 514731 [details]
Fix, pass 2
Comment 13 Lon Hohberger 2011-07-22 16:23:36 UTC 
Clarification:

* this feature must not introduce regressions in the schema; existing
configurations must still validate

* this feature must cause the ccs_update_schema program to generate
machine-readable hints which may be used by a UI or other program to associate
groups of parameters with fencing agents

* These hints must be stored in the cluster relaxng schema, or /usr/share/cluster/cluster.rng (which may be a symlink to another location)
Comment 14 Fabio Massimo Di Nitto 2011-07-22 16:38:19 UTC 
(In reply to comment #10)
> Created attachment 514731 [details]
> Fix, pass 2

Patch looks good. ACK
Comment 15 Lon Hohberger 2011-07-22 16:54:58 UTC 
Preliminary test results (development build):

[root@snap ~]# ccs_update_schema
[root@snap ~]# echo $?
0
[root@snap ~]# grep fence_wti /usr/share/cluster/cluster.rng
      <!-- fence_wti -->
      <group rha:name="fence_wti" rha:description="Fence agent for WTI">
Comment 16 Lon Hohberger 2011-07-22 16:57:10 UTC 
http://git.fedorahosted.org/git?p=fence-agents.git;a=commit;h=7e570a1773f11afa9982ee1ed72c3482640dc52a
Comment 17 Lon Hohberger 2011-07-22 17:10:25 UTC 
[root@snap ~]# rpm -q fence-agents
fence-agents-3.1.5-2.el6.x86_64
[root@snap ~]# ccs_update_schema ; echo $?
0
[root@snap ~]# ccs_config_validate ; echo $?
Configuration validates
0
[root@snap ~]# grep fence_wti /usr/share/cluster/cluster.rng 
      <!-- fence_wti -->
      <group rha:name="fence_wti" rha:description="Fence agent for WTI">
[root@snap ~]# grep fence_xvm /usr/share/cluster/cluster.rng
Comment 18 Lon Hohberger 2011-07-22 17:11:40 UTC 
Oops - left it hanging:

[root@snap ~]# grep fence_xvm /usr/share/cluster/cluster.rng 
- fence_xvmd
<!-- fence_xvmd block -->
  <element name="fence_xvmd" rha:description="Fence_xvm daemon. The
      fence_xvmd fence device is an I/O fencing host that resides
      on dom0 and is used in conjunction with the fence_xvm fencing
<!-- end fence_xvmd block -->
      <!-- fence_xvm -->
      <group rha:name="fence_xvm" rha:description="Fence agent for virtual machines">
          <attribute name="key_file" rha:description="Shared key file (default=/etc/cluster/fence_xvm.key)" />
          <attribute name="use_uuid" rha:description="Treat [domain] as UUID instead of domain name. This is provided for compatibility with older fence_xvmd installations." />
Comment 21 Martin Juricek 2011-08-24 09:19:47 UTC 
Verified in version fence-agents-3.1.5-7.el6, kernel 2.6.32-191.el6


[root@z2 ~]# rpm -q fence-agents
fence-agents-3.1.5-7.el6.x86_64
[root@z2 ~]# ccs_update_schema 
[root@z2 ~]# echo $?
0
[root@z2 ~]# ccs_config_validate 
Configuration validates
[root@z2 ~]# echo $?
0
[root@z2 ~]# grep fence_wti /usr/share/cluster/cluster.rng
      <!-- fence_wti -->
      <group rha:name="fence_wti" rha:description="Fence agent for WTI">
[root@z2 ~]# grep fence_xvm /usr/share/cluster/cluster.rng
- fence_xvmd
<!-- fence_xvmd block -->
  <element name="fence_xvmd" rha:description="Fence_xvm daemon. The
      fence_xvmd fence device is an I/O fencing host that resides
      on dom0 and is used in conjunction with the fence_xvm fencing
<!-- end fence_xvmd block -->
      <!-- fence_xvm -->
      <group rha:name="fence_xvm" rha:description="Fence agent for virtual machines">
          <attribute name="key_file" rha:description="Shared key file (default=/etc/cluster/fence_xvm.key)" />
          <attribute name="use_uuid" rha:description="Treat [domain] as UUID instead of domain name. This is provided for compatibility with older fence_xvmd installations." />
[root@z2 ~]#
Comment 22 errata-xmlrpc 2011-12-06 12:22:46 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1599.html