| Summary: | test in taint.t is not correct | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Marcela Mašláňová <mmaslano> | ||||
| Component: | perl | Assignee: | Petr Pisar <ppisar> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Martin Kyral <mkyral> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 6.2 | CC: | lnovich, mkyral, ppisar, psabata | ||||
| Target Milestone: | rc | Keywords: | EasyFix, Patch | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | perl-5.10.1-133.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: |
Cause:
Running tests suite at build-time.
Consequence:
Tests for CVE-2011-1487 could pass even if the
CVE-2011-1487 vulnerability has not been fixed properly.
Fix:
Internal tests in t/op/taint.t have been corrected to
check taintedness indeed.
Result:
Internal test suite run at build-time would fail if
CVE-2011-1487 had not been fixed properly.
|
Story Points: | --- | ||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-11-21 04:40:00 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
|
Description
Marcela Mašláňová
2011-04-21 08:21:30 UTC
Created attachment 493741 [details]
tain.t patch fixes previous incorrect testing
(In reply to comment #0) > People from Debian were porting our patch from Fedora 13 for perl-5.10.1. The our patch is patch for bug #692862. This request was evaluated by Red Hat Product Management for inclusion in the current release of Red Hat Enterprise Linux. Because the affected component is not scheduled to be updated in the current release, Red Hat is unfortunately unable to address this request at this time. Red Hat invites you to ask your support representative to propose this request, if appropriate and relevant, in the next release of Red Hat Enterprise Linux. If you would like it considered as an exception in the current release, please ask your support representative. The difference is:
--- a/t/op/taint.t
+++ b/t/op/taint.t
@@ -1320,13 +1320,13 @@ foreach my $ord (78, 163, 256) {
# [perl #87336] lc/uc(first) failing to taint the returned string
my $source = "foo$TAINT";
my $dest = lc $source;
- test $dest, "lc(tainted) taints its return value";
+ test tainted $dest, "lc(tainted) taints its return value";
$dest = lcfirst $source;
- test $dest, "lcfirst(tainted) taints its return value";
+ test tainted $dest, "lcfirst(tainted) taints its return value";
$dest = uc $source;
- test $dest, "uc(tainted) taints its return value";
+ test tainted $dest, "uc(tainted) taints its return value";
$dest = ucfirst $source;
- test $dest, "ucfirst(tainted) taints its return value";
+ test tainted $dest, "ucfirst(tainted) taints its return value";
}
# This may bomb out with the alarm signal so keep it last
This will be fixed by editing perl-5.10.1-lc_launders_taint.patch.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2013-1534.html |