| Summary: | Review Request: pal - Command line calendar that displays holidays and events | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Martin Cermak <mcermak> |
| Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | anton, fedora-package-review, hdegoede, notting, packages |
| Target Milestone: | --- | Flags: | hdegoede:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | pal-0.4.3-2.fc15 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-05-25 02:54:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Martin Cermak
2011-04-21 09:38:41 UTC
I'll review this (and your other submission), and assuming all goes well sponsor you eventually, removing FE_NEEDSPONSOR blocker. Full review done, results: Good: ===== - rpmlint checks return: pal.src: W: spelling-error %description -l en_US gcal -> gal, cal, goal pal.x86_64: W: spelling-error %description -l en_US gcal -> gal, cal, goal These can be ignored - package meets naming guidelines - package meets packaging guidelines - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - locales handled properly - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Needs work: =========== - rpmlint checks return: pal-debuginfo.x86_64: E: empty-debuginfo-package This is caused by the Makefile stripping the binary directly after the build, you can stop it from doing this by passing DEBUG=1 on the make cmdline. - The license should be GPLv2+ - Fedora has a standard url for sf.net downloads, please use: Source0: http://downloads.sourceforge.net/palcal/pal-%{version}.tgz - No need to pass: " -n %{name}-%{version}" to %setup, this is the default - The preferred form for %defattr in fedora is: %defattr(-,root,root,-) - The files under %{_datadir}/doc/pal-%{version} should be marked as %doc, not gzipped and not include INSTALL. The easiest way is to add the following line to %files: %doc doc/example.css COPYING ChangeLog Note traditionally this lines comes directly after the %defattr line I see no SCM request to process here. Perhaps the wrong flag was set by mistake? (In reply to comment #3) > I see no SCM request to process here. Perhaps the wrong flag was set by > mistake? My bad, I meant to set fedora-review to ?, same for bug 700833, don't know how this happened... Uhm, could you please read the description again? "Pal is command-line calendar program that can keep track of events pal is a command-line calendar program for Unix/Linux systems that can keep track of events. [...]" I think this should really be corrected (e.g. remove the first part until "pal is a..."). (In reply to comment #5) > Uhm, could you please read the description again? > > "Pal is command-line calendar program that can keep track of events pal is a > command-line calendar program for Unix/Linux systems that can keep track of > events. [...]" > > I think this should really be corrected (e.g. remove the first part until "pal > is a..."). Agreed, Martin you can add that to the needswork list... I belive pal-0.4.3-2 contains all the requested fixes: Spec URL: http://www.physics.muni.cz/~cermak/pal-0.4.3-2/pal.spec SRPM URL: http://www.physics.muni.cz/~cermak/pal-0.4.3-2/pal-0.4.3-2.fc14.src.rpm + rpmlint pal.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. + rpmlint pal-0.4.3-2.fc14.src.rpm pal.src: W: spelling-error %description -l en_US gcal -> gal, cal, goal 1 packages and 0 specfiles checked; 0 errors, 1 warnings. + rpmlint pal-debuginfo-0.4.3-2.fc14.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. + rpmlint pal-0.4.3-2.fc14.x86_64.rpm pal.x86_64: W: spelling-error %description -l en_US gcal -> gal, cal, goal 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Hans, please, review my changes. Looks good now, approved! If you can go and create a fas account (if you've not done so already) and tell me your fas username, I'll add you to the packager group and sponsor you, see: http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_a_Fedora_Account Great, thanks! My fas username is mcermak. What should I do next? Hi, (In reply to comment #9) > Great, thanks! My fas username is mcermak. What should I do next? I've just added you to the packager group and sponsored you, the next steps, are described here: http://fedoraproject.org/wiki/PackageMaintainers/Join The first thing to do is request creation of git and bugzilla modules for your approved packages, see: http://fedoraproject.org/wiki/Package_SCM_admin_requests Note that it may take up to an hour for your newer packager rights to propagate to all servers, and you won't be able to set the fedora-cvs flag until you've those rights. Regards, Hans New Package SCM Request ======================= Package Name: pal Short Description: Command line calendar that displays holidays and events Owners: mcermak Branches: f14 f15 InitialCC: jwrdegoede Git done (by process-git-requests). pal-0.4.3-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/pal-0.4.3-2.fc14 pal-0.4.3-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/pal-0.4.3-2.fc15 pal-0.4.3-2.fc14 has been pushed to the Fedora 14 testing repository. pal-0.4.3-2.fc14 has been pushed to the Fedora 14 stable repository. pal-0.4.3-2.fc15 has been pushed to the Fedora 15 stable repository. |